Enable PVP flow for SDK repo #16633
Merged
Enable PVP flow for SDK repo #16633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
approved these changes
Jun 9, 2023
|
Investigating failures... |
Not sure if this is related to |
|
Latest command-line-api changes haven't flown in yet. |
|
Hmm, this is odd, local build with an older base sha works fine, but this one is trying to use a reference assembly: |
|
Found the root cause - testing the fix locally. |
2 more dependencies uncovered as reference assemblies in produced SDK - working on fix. Will update this PR over the weekend and prepare a fix for SDK repo. |
NikolaMilosavljevic
force-pushed
the
sdk.pvp
branch
from
32918ab
to
c288b66
Compare
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/source-build#3043
Enables PVP flow for
sdkrepo. Includes a patch forsdkchanges, to enable early end-to-end validations.