Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore warnings of IDE0090 for vstest #17253

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Ignore warnings of IDE0090 for vstest #17253

merged 3 commits into from
Aug 25, 2023

Conversation

mthalman
Copy link
Member

@mthalman mthalman commented Aug 24, 2023 •
edited
Loading

The following error is occurring in the stage 2 bootstrapping build of the VMR:

/vmr/src/vstest/artifacts/source-build/self/src/src/Microsoft.TestPlatform.Extensions.BlameDataCollector/ProcessCodeMethods.cs(71,48): error IDE0090: 'new' expression can be simplified (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0090) [/vmr/src/vstest/artifacts/source-build/self/src/src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Microsoft.TestPlatform.Extensions.BlameDataCollector.csproj::TargetFramework=net8.0]

This is fixed by ignoring the IDE0090 warning.

Related to microsoft/vstest#4674

@mthalman mthalman requested a review from a team as a code owner August 24, 2023 20:36
MichaelSimons
MichaelSimons approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you ensure a vstest issue is opened to address this warning when building with the latest toolset?

@mthalman mthalman enabled auto-merge (squash) August 25, 2023 15:15
@mthalman mthalman merged commit b1fa912 into dotnet:release/8.0.1xx Aug 25, 2023
15 of 18 checks passed
@mthalman mthalman deleted the IDE0090 branch August 25, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSimons MichaelSimons MichaelSimons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mthalman @MichaelSimons