Format tests should be skipped on Alpine #17268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR enabled skipping Format tests on Alpine, if an environment variable is set: #17247
However, this is not a good experience for anyone building and testing on Alpine. See this for more context: #17247 (comment)
A better experience is to not execute the test on Alpine, by utilizing
Config.TargetRidand return from test method early. This would mark the test asPassed.Even better experience would be to really skip the test dynamically, however we do not support XUnit v3, which provides
SkipWhenmethod: https://github.com/xunit/xunit/blob/main/src/xunit.v3.assert.tests/Asserts/SkipAssertsTests.cs