Skip BasicScenarioTests.cs and WebScenarioTests.cs for PublishComplex action #17313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
reviewed
Sep 6, 2023
src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/BasicScenarioTests.cs
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/DotNetHelper.cs
Outdated
Show resolved
Hide resolved
mthalman
reviewed
Sep 7, 2023
src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/DotNetHelper.cs
Outdated
Show resolved
Hide resolved
mthalman
approved these changes
Sep 8, 2023
| return false; | ||
| } | ||
| else | ||
| return true; |
There was a problem hiding this comment.
Nit: inconsistent brace style with if body.
Suggested change
| return true; | |
| { | |
| return true; | |
| } |
This could be simplified this to use an expression bodied method.
public static bool ShouldPublishComplex() =>
string.Equals(Config.TargetArchitecture,"ppc64le") || string.Equals(Config.TargetArchitecture,"s390x");
MichaelSimons
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3614
This PR is to skip BasicScenarioTests.cs and WebScenarioTests.cs test cases for ppc64le and s390x arch.