Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branding 8.0.2xx #17408

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Branding 8.0.2xx #17408

merged 1 commit into from
Sep 27, 2023

Conversation

Forgind
Copy link
Member

@Forgind Forgind commented Sep 22, 2023

  • Please add description for changes you are making.
  • If there is an issue related to this PR, please add the reference.

@Forgind Forgind requested review from a team as code owners September 22, 2023 18:25
@Forgind Forgind changed the base branch from main to release/8.0.2xx September 22, 2023 18:26
Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this 😄

@nagilson
Copy link
Member

I think there may need to be another PR to update the installer table though, @Forgind did the branding instructions mention that? If not, we should maybe cc marcpop to ask.

@Forgind
Copy link
Member Author

Forgind commented Sep 26, 2023

Well, that was supposed to be #17409, and I think the last commit does that...but I'll just say there are an unfortunate number of commits total...

@Forgind
Copy link
Member Author

Forgind commented Sep 26, 2023

Alright; you can look now 🙂

@nagilson
Copy link
Member

I think you're good to merge!

@Forgind Forgind merged commit 62b7bde into dotnet:release/8.0.2xx Sep 27, 2023
18 checks passed
@Forgind Forgind deleted the branding-8.0.2xx branch September 27, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants