Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebootstrap SB SDK/artifacts #18763

Merged
merged 10 commits into from
Mar 8, 2024
Merged

Rebootstrap SB SDK/artifacts #18763

merged 10 commits into from
Mar 8, 2024

Conversation

mthalman
Copy link
Member

This is necessary in order to get a new SDK with a fixed version of the crossgen2 tool for resolving dotnet/source-build#4007

@mthalman mthalman requested a review from a team as a code owner February 23, 2024 20:29
@mthalman
Copy link
Member Author

Dealing with some incoherency issues here, I think.

First commit:

    /vmr/src/aspnetcore/src/Mvc/Mvc.Api.Analyzers/src/Microsoft.AspNetCore.Mvc.Api.Analyzers.csproj : error NU1605: Warning As Error: Detected package downgrade: System.Collections.Immutable from 9.0.0-preview.2.24123.1 to 9.0.0-preview.2.24122.4. Reference the package directly from the project to select a different version.  [/vmr/.dotnet/sdk/9.0.100-preview.2.24123.4/NuGet.targets]
    /vmr/src/aspnetcore/src/Mvc/Mvc.Api.Analyzers/src/Microsoft.AspNetCore.Mvc.Api.Analyzers.csproj : error NU1605:  Microsoft.AspNetCore.Mvc.Api.Analyzers -> Microsoft.CodeAnalysis.CSharp.Workspaces 4.10.0-2.24122.3 -> Microsoft.CodeAnalysis.Common 4.10.0-2.24122.3 -> System.Collections.Immutable (>= 9.0.0-preview.2.24123.1)  [/vmr/.dotnet/sdk/9.0.100-preview.2.24123.4/NuGet.targets]
    /vmr/src/aspnetcore/src/Mvc/Mvc.Api.Analyzers/src/Microsoft.AspNetCore.Mvc.Api.Analyzers.csproj : error NU1605:  Microsoft.AspNetCore.Mvc.Api.Analyzers -> Microsoft.CodeAnalysis.CSharp.Workspaces 4.10.0-2.24122.3 -> System.Collections.Immutable (>= 9.0.0-preview.2.24122.4) [/vmr/.dotnet/sdk/9.0.100-preview.2.24123.4/NuGet.targets]

Second commit (using the output from an earlier VMR build):

/vmr/src/command-line-api/src/System.CommandLine/System.CommandLine.csproj(0,0): error NU1102: (NETCORE_ENGINEERING_TELEMETRY=Restore) Unable to find package Microsoft.NET.ILLink.Tasks with version (>= 9.0.0-preview.2.24122.4)
  - Found 1015 version(s) in dotnet8 [ Nearest version: 8.0.100-1.23067.1 ]
  - Found 176 version(s) in dotnet5 [ Nearest version: 5.0.0-rtm.20509.1 ]
  - Found 22 version(s) in dotnet5-transport [ Nearest version: 5.0.0-rtm.21519.5 ]
  - Found 17 version(s) in dotnet-public [ Nearest version: 9.0.0-preview.1.24080.9 ]
  - Found 1 version(s) in previously-source-built [ Nearest version: 9.0.0-preview.2.24120.11 ]
  - Found 0 version(s) in source-built-transport-arcade
  - Found 0 version(s) in prebuilt
  - Found 0 version(s) in reference-packages
  - Found 0 version(s) in dotnet-eng
  - Found 0 version(s) in dotnet-libraries
  - Found 0 version(s) in dotnet-tools

@mthalman
Copy link
Member Author

The failures in the unified-build pipeline are caused by #18768

@mthalman
Copy link
Member Author

/azp run installer-source-build

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mthalman
Copy link
Member Author

/backport to release/9.0.1xx-preview2

Copy link

Started backporting to release/9.0.1xx-preview2: https://github.com/dotnet/installer/actions/runs/8067367487

@mthalman
Copy link
Member Author

mthalman commented Mar 4, 2024

@KevinRansom - Can you take a look at these F# failures that are occurring in the VMR build (specifically the installer-source-build pipeline)? The changes that are being made here are to update the SDK version that is used by the build. That's running into a bunch of these FS1118 errors:

##[error]/vmr/src/fsharp/src/FSharp.Core/array.fs(2297,17): error FS1118: Failed to inline the value 'groupByImplParallel' marked 'inline', perhaps because a recursive value was marked 'inline' [/vmr/src/fsharp/src/FSharp.Core/FSharp.Core.fsproj::TargetFramework=netstandard2.1]

Do your recent changes in dotnet/fsharp#15484 potentially resolve this? Those changes haven't flowed into installer yet. Or otherwise, do you know what should be done to fix this?

@mthalman
Copy link
Member Author

mthalman commented Mar 5, 2024

The unified-build pipeline is running into the same error as dotnet/sdk#39050 (comment) which was fixed there. Merging in latest to get that fix.

@mthalman
Copy link
Member Author

mthalman commented Mar 6, 2024

Errors in aspnetcore for installer-source-build:

/vmr/src/aspnetcore/src/Analyzers/Analyzers/src/Microsoft.AspNetCore.Analyzers.csproj(0,0): error NU1605: (NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: Detected package downgrade: System.Collections.Immutable from 9.0.0-preview.3.24154.10 to 9.0.0-preview.2.24128.5. Reference the package directly from the project to select a different version. 
 Microsoft.AspNetCore.Analyzers -> Microsoft.CodeAnalysis.CSharp 4.10.0-3.24151.8 -> Microsoft.CodeAnalysis.Common 4.10.0-3.24151.8 -> System.Collections.Immutable (>= 9.0.0-preview.3.24154.10) 
 Microsoft.AspNetCore.Analyzers -> Microsoft.CodeAnalysis.CSharp 4.10.0-3.24151.8 -> System.Collections.Immutable (>= 9.0.0-preview.2.24128.5)

Pretty sure this is because the Roslyn version is the same between the preview.2 source built artifacts being used to bootstrap with and the version of Roslyn that's currently being built in the VMR. It causes non-determinism on which package gets used by source build.

Waiting on #18875 to be merged which will upgrade the Roslyn version so that it won't conflict.

@mthalman mthalman requested a review from a team as a code owner March 7, 2024 13:33
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the Arcade Sdk entry in global.json need to be updated as well?

@mthalman
Copy link
Member Author

mthalman commented Mar 7, 2024

Getting a whole bunch of test failures when attempting to run dotnet build in the tests:

/vmr/test/Microsoft.DotNet.SourceBuild.SmokeTests/bin/Release/net9.0/.dotnet/sdk/9.0.100-preview.3.24157.1/NuGet.targets(169,5): error : Method not found: 'NuGet.ProjectModel.DependencyGraphSpec NuGet.Commands.MSBuildRestoreUtility.GetDependencySpec(System.Collections.Generic.IEnumerable`1<NuGet.Commands.IMSBuildItem>, Boolean)'. [/vmr/test/Microsoft.DotNet.SourceBuild.SmokeTests/bin/Release/net9.0/projects-202403071432110267/WebScenarioTests_WebApi_CSharp/WebScenarioTests_WebApi_CSharp.csproj]

System.MissingMethodException: Method not found: 'NuGet.ProjectModel.DependencyGraphSpec NuGet.Commands.MSBuildRestoreUtility.GetDependencySpec(System.Collections.Generic.IEnumerable`1<NuGet.Commands.IMSBuildItem>, Boolean)'.
   at NuGet.Build.Tasks.RestoreTask.ExecuteAsync(ILogger log)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at NuGet.Build.Tasks.RestoreTask.ExecuteAsync(ILogger log)
   at NuGet.Build.Tasks.RestoreTask.Execute()

This method was newly added in NuGet/NuGet.Client#5645.

@mthalman mthalman merged commit 360eff1 into dotnet:main Mar 8, 2024
22 checks passed
@mthalman mthalman deleted the bootstrap branch March 8, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants