Add registry search for upgrade policy keys #20106
Conversation
| @@ -393,7 +396,7 @@ | |||
| InstallerFile="$(CombinedFrameworkSdkHostMSIInstallerFile)" | |||
| WixExtensions="WixBalExtension;WixUtilExtension;WixTagExtension" | |||
| WixSrcFiles="@(BundleMsiWixSrcFiles)" | |||
| AdditionalBasePaths="$(MSBuildThisFileDirectory)packaging/windows/clisdk"> | |||
| AdditionalBasePaths="$(MSBuildThisFileDirectory)packaging/windows/clisdk;$(PkgMicrosoft_DotNet_Build_Tasks_Installers)\build\wix\bundle"> | |||
There was a problem hiding this comment.
What is this property used for? There are 2 other references to this property in other LightCommandPackageDrop creations. Should those also provide $(PkgMicrosoft_DotNet_Build_Tasks_Installers)\build\wix\bundle?
There was a problem hiding this comment.
It modifies when/how we'd perform upgrades.
There was a problem hiding this comment.
Thank you for the explanations.
|
Depends on merging dotnet/arcade#15047 and having that flow into the installer repo |
|
/backport to release/8.0.3xx |
|
/backport to release/8.0.4xx |
|
Started backporting to release/8.0.3xx: https://github.com/dotnet/installer/actions/runs/11184350561 |
|
Started backporting to release/8.0.4xx: https://github.com/dotnet/installer/actions/runs/11184352998 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Description
Add registry search operations to SDK installer bundles. The search operation will check for a global and version specific registry key. The version specific key takes precedence when present.
This is related to a customer request and part of a larger change. This PR only includes infrastructure changes to support changes in the Windows installer bundles. The change depends on changes in Arcade (dotnet/arcade#15047).
NB: This PR will not build until the Arcade change is merged and flowed to the SDK.
Unlike the runtime and desktop runtime, the SDK needs to explicitly pull in the additional source file.
Risk
Low, this change only adds detection for the key, nothing will currently act on its value.
Testing
Testing can be done once all the relevant Arcade/Wix changes are merged and have flowed through.