Remove obj/ from Compile in Java.Interop-MonoAndroid.csproj #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After dotnet@95712a2 we now hit the opposite condition. The SDK-style build of Java.Interop.csproj generates "obj/Release/netstandard2.0/.NETStandard,Version=v2.0.AssemblyAttributes.cs" which is now included by the `<Compile Include="**\*.cs" />` in Java.Interop-MonoAndroid.csproj Fix this by adding back the removal of .cs files in obj/.
jonpryor
pushed a commit
that referenced
this pull request
Feb 26, 2020
After commit 95712a2 we now hit the opposite condition: The SDK-style build of `Java.Interop.csproj` generates `obj/Release/netstandard2.0/.NETStandard,Version=v2.0.AssemblyAttributes.cs` which is now included by the `<Compile Include="**\*.cs" />` within `Java.Interop-MonoAndroid.csproj`. Fix this by adding back the removal of `obj\**\**.cs` files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 95712a2 we now hit the opposite condition.
The SDK-style build of Java.Interop.csproj generates "obj/Release/netstandard2.0/.NETStandard,Version=v2.0.AssemblyAttributes.cs" which is now included by the
<Compile Include="**\*.cs" />in Java.Interop-MonoAndroid.csproj.Changing the
BaseIntermediateOutputPathis more complicated for SDK-style projects due to the way the common targets are imported: dotnet/msbuild#1603. The easiest fix is adding back the removal of .cs files in obj/.