Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UnconditionalSuppressMessageAttribute #1185

Merged
merged 37 commits into from
May 29, 2020
Merged

Add UnconditionalSuppressMessageAttribute #1185

merged 37 commits into from
May 29, 2020

Commits on Apr 30, 2020

  1. Log errors via MessageContainer

    Mateo Torres Ruiz committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    1f70684 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2020

  1. Use LinkerErrorExceptions for all throws. Don't stop linker on first … 

    …error found.
    Mateo Torres Ruiz committed May 4, 2020
    Configuration menu
    Copy the full SHA
    3ee5a98 View commit details
    Browse the repository at this point in the history

  2. Move FoundErrors to LinkContext and clean exceptions.

    Mateo Torres Ruiz committed May 4, 2020
    Configuration menu
    Copy the full SHA
    018b132 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. Move errors to new md file.

    Mateo Torres Ruiz committed May 5, 2020
    Configuration menu
    Copy the full SHA
    15b93c1 View commit details
    Browse the repository at this point in the history

  2. Use same code for errors with same message.

    Mateo Torres Ruiz committed May 5, 2020
    Configuration menu
    Copy the full SHA
    37ba56d View commit details
    Browse the repository at this point in the history

  3. Fix test and whitespace formatting

    Mateo Torres Ruiz committed May 5, 2020
    Configuration menu
    Copy the full SHA
    a0998e5 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Update exit message 

    Co-authored-by: Marek Safar <[email protected]>
    @mateoatr @marek-safar
    mateoatr and marek-safar authored May 6, 2020
    Configuration menu
    Copy the full SHA
    1ac3a2d View commit details
    Browse the repository at this point in the history

  2. Add error for unexpected scenarios.

    Mateo Torres Ruiz committed May 6, 2020
    Configuration menu
    Copy the full SHA
    5ab700b View commit details
    Browse the repository at this point in the history

Commits on May 7, 2020

  1. Print all inner exceptions.

    Mateo Torres Ruiz committed May 7, 2020
    Configuration menu
    Copy the full SHA
    5ec1844 View commit details
    Browse the repository at this point in the history

  2. Resolve merge conflicts

    Mateo Torres Ruiz committed May 7, 2020
    Configuration menu
    Copy the full SHA
    cf4b5af View commit details
    Browse the repository at this point in the history

  3. Update FeatureSubstitutionsInvalid test.

    Mateo Torres Ruiz committed May 7, 2020
    Configuration menu
    Copy the full SHA
    e9bc9dc View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. Add UnconditionalSuppressMessage attribute.

    Mateo Torres Ruiz committed May 13, 2020
    Configuration menu
    Copy the full SHA
    20c4eea View commit details
    Browse the repository at this point in the history

  2. Merge with master

    Mateo Torres Ruiz committed May 13, 2020
    Configuration menu
    Copy the full SHA
    6dca600 View commit details
    Browse the repository at this point in the history

  3. Make MessageOrigin overload internal. Allow nullable on Unconditional… 

    …SuppressMessageAttribute's copy.
    Mateo Torres Ruiz committed May 13, 2020
    Configuration menu
    Copy the full SHA
    7c18a45 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2020

  1. Merge branch 'master' of https://github.com/mono/linker into Uncondit… 

    …ionalSuppressMessage
    Mateo Torres Ruiz committed May 15, 2020
    Configuration menu
    Copy the full SHA
    802e614 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. Make MessageOrigin mandatory for warnings

    Mateo Torres Ruiz committed May 20, 2020
    Configuration menu
    Copy the full SHA
    af143b7 View commit details
    Browse the repository at this point in the history

  2. Add CreateWarningMessage overloads to make it cleaner

    Mateo Torres Ruiz committed May 20, 2020
    Configuration menu
    Copy the full SHA
    0de4956 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/mono/linker into Uncondit… 

    …ionalSuppressMessage
    Mateo Torres Ruiz committed May 20, 2020
    Configuration menu
    Copy the full SHA
    297e925 View commit details
    Browse the repository at this point in the history

  4. Merge with master

    Mateo Torres Ruiz committed May 20, 2020
    Configuration menu
    Copy the full SHA
    7ba1784 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2020

  1. Address feedback

    Mateo Torres Ruiz committed May 21, 2020
    Configuration menu
    Copy the full SHA
    2bf9add View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Vitek Karas <[email protected]>
    @mateoatr @vitek-karas
    mateoatr and vitek-karas authored May 21, 2020
    Configuration menu
    Copy the full SHA
    5a9f126 View commit details
    Browse the repository at this point in the history

  3. Keep only changes relevant to local suppressions.

    Mateo Torres Ruiz committed May 21, 2020
    Configuration menu
    Copy the full SHA
    bcc95a5 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary castings.

    Mateo Torres Ruiz committed May 21, 2020
    Configuration menu
    Copy the full SHA
    ee00fb5 View commit details
    Browse the repository at this point in the history

  5. Fix whitespace formatting 

    Enable nullable ref types
    Mateo Torres Ruiz committed May 21, 2020
    Configuration menu
    Copy the full SHA
    db89657 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2020

  1. Fix mono build

    Mateo Torres Ruiz committed May 22, 2020
    Configuration menu
    Copy the full SHA
    17910cb View commit details
    Browse the repository at this point in the history

  2. Update UnconditionalSuppressMessageAttributeState.cs with suggestion 

    Co-authored-by: Vitek Karas <[email protected]>
    @mateoatr @vitek-karas
    mateoatr and vitek-karas authored May 22, 2020
    Configuration menu
    Copy the full SHA
    e97b422 View commit details
    Browse the repository at this point in the history

  3. Address feedback

    Mateo Torres Ruiz committed May 22, 2020
    Configuration menu
    Copy the full SHA
    6e387e3 View commit details
    Browse the repository at this point in the history

  4. Remove AddOrUpdate

    Mateo Torres Ruiz committed May 22, 2020
    Configuration menu
    Copy the full SHA
    02c5196 View commit details
    Browse the repository at this point in the history

  5. TryAdd is only supported in .NET Core 

    This changes the behavior of AddLocalSuppression to add or update a (provider, id) tuple with the last seen suppression instead of keeping the first one seen.
    Mateo Torres Ruiz committed May 22, 2020
    Configuration menu
    Copy the full SHA
    f90d38b View commit details
    Browse the repository at this point in the history

  6. Store only the integer value of the warning id

    Mateo Torres Ruiz committed May 22, 2020
    Configuration menu
    Copy the full SHA
    baa1c77 View commit details
    Browse the repository at this point in the history

  7. Don't use regex for simple parsing

    Mateo Torres Ruiz committed May 22, 2020
    Configuration menu
    Copy the full SHA
    7997b93 View commit details
    Browse the repository at this point in the history

  8. Check that warning id starts with 'IL'

    Mateo Torres Ruiz committed May 22, 2020
    Configuration menu
    Copy the full SHA
    0492a0f View commit details
    Browse the repository at this point in the history

  9. Missed '!'

    Mateo Torres Ruiz committed May 22, 2020
    Configuration menu
    Copy the full SHA
    c4b0483 View commit details
    Browse the repository at this point in the history

  10. Check if first character after warning code is a colon

    Mateo Torres Ruiz committed May 22, 2020
    Configuration menu
    Copy the full SHA
    87e79fc View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. Use ICustomAttributeProvider as key for local suppressions 

    Check for null before calling `ToLower` on `Scope` parameter

Use IMemberDefinition instead of IMdToken for specifying the MessageOrigin
    Mateo Torres Ruiz committed May 28, 2020
    Configuration menu
    Copy the full SHA
    c4ad9ad View commit details
    Browse the repository at this point in the history

  2. Merge with master

    Mateo Torres Ruiz committed May 28, 2020
    Configuration menu
    Copy the full SHA
    519ea2c View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. Whitespace formatting

    Mateo Torres Ruiz committed May 29, 2020
    Configuration menu
    Copy the full SHA
    c5d8b2e View commit details
    Browse the repository at this point in the history