Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature parser based on Roslyn doc comments #1197

Merged
merged 9 commits into from
May 27, 2020

Commits on May 16, 2020

  1. Configuration menu
    Copy the full SHA
    6194fd4 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. Fix formatting

    sbomer committed May 18, 2020
    Configuration menu
    Copy the full SHA
    6481bba View commit details
    Browse the repository at this point in the history
  2. PR feedback

    - SignatureParser -> DocumentationSignatureParser
    - GetSignaturePart extension moved to DocumentationSignatureParser
    - Inverted a condition
    - Added a clarifying comment about generics
    sbomer committed May 18, 2020
    Configuration menu
    Copy the full SHA
    9deb282 View commit details
    Browse the repository at this point in the history
  3. Avoid ImmutableArray

    To let it build on mono
    sbomer committed May 18, 2020
    Configuration menu
    Copy the full SHA
    b22e8ed View commit details
    Browse the repository at this point in the history
  4. Rename test attributes

    And add comments clarifying their behavior
    sbomer committed May 18, 2020
    Configuration menu
    Copy the full SHA
    a3c12da View commit details
    Browse the repository at this point in the history
  5. Fix mono test failure

    There were two issues:
    - Nunit doesn't like assertions inside of a TestCaseSource method.
    - On mono, the test infra failed to resolve the new assertion attributes
    sbomer committed May 18, 2020
    Configuration menu
    Copy the full SHA
    ebc03db View commit details
    Browse the repository at this point in the history

Commits on May 26, 2020

  1. Factor parser for use from DynamicDependencyAttribute

    - Allow parsing a signature without a member type prefix
    - Allow parsing a member without a type name
    - Allow matching multiple member kinds
    - Rename some public methods to more closely match linker terminology
    - Add a few more tests for edge cases
    sbomer committed May 26, 2020
    Configuration menu
    Copy the full SHA
    647924d View commit details
    Browse the repository at this point in the history
  2. PR feedback

    - License headers
    - Don't use string interpolation
    - Don't use extension method for GetSignaturePart
    - Remove unnecessary nullable context
    - Remove unnecessary IndexOf
    sbomer committed May 26, 2020
    Configuration menu
    Copy the full SHA
    c8613eb View commit details
    Browse the repository at this point in the history
  3. Update link for edge cases

    sbomer committed May 26, 2020
    Configuration menu
    Copy the full SHA
    f016525 View commit details
    Browse the repository at this point in the history