Add more warning suppression scenarios #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitek-karas
requested changes
Jun 2, 2020
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Vitek Karas <[email protected]>
marek-safar
reviewed
Jun 2, 2020
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
added 2 commits
June 2, 2020 12:35
…suppressions Use switch-case for the attributes module
marek-safar
reviewed
Jun 3, 2020
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
vitek-karas
reviewed
Jun 3, 2020
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
| @@ -99,10 +106,127 @@ private static bool TryDecodeSuppressMessageAttributeData (CustomAttribute attri | |||
|
|
|||
| private bool IsLocallySuppressed (int id, ICustomAttributeProvider provider, out SuppressMessageInfo info) | |||
There was a problem hiding this comment.
Not for this PR but eventually we should cleanup the types here. The warning requires the "location" to be IMemberDefinition, but then all of the suppression logic works on ICustomAttributeProvider. Would be nice to unify this.
For example it's possible to suppress a warning at the assembly level, but currently it's not possible to emit a warning at the assembly level.
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/linker/Linker/UnconditionalSuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
Remove GlobalSuppressions class Refactor methods
vitek-karas
approved these changes
Jun 3, 2020
marek-safar
approved these changes
Jun 4, 2020
tkapin
pushed a commit
to tkapin/runtime
that referenced
this pull request
Jan 31, 2023
Co-authored-by: Vitek Karas <[email protected]> Commit migrated from dotnet/linker@ba6d3da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing with the work of #1185 this PR adds the ability to suppress warnings throughout a module or assembly. It also adds support for using the
TargetandScopeproperties for global suppression on types and members.