[release/6.0.x] Update cecil to the same version as main as of 3/25/2022 #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the fix for dotnet#2203 into 6.0. The same fix has been in the linker/main for 2 months now and it shipped in 7.0 preview without any issues.
agocke
changed the title
agocke
approved these changes
Mar 31, 2022
|
@vitek-karas this will break the assembly deduplication on Android, let's talk about what options we have tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer Impact
Fixes #2203
The version of cecil in the 6.0.x SDK does not properly update the hashes of binaries when they are modified, resulting in colliding PDB hashes, and inability to fetch symbols for binaries. This affects many binaries in 6.0.3 and makes them undebugable in VS using the standard symbol servers.
Testing
Unit tests. The same fix has also been in the linker/main for 2 months now and it shipped in 7.0 preview without any issues.
Risk
Low-medium. Cecil has had very few modifications since 6.0, mostly just this fix. This was a targeted fix, but it does involve a change to Cecil. No reports of problems with 7.0 preview provides some confidence.