License expression #6674
Merged
License expression #6674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LittleLittleCloud
approved these changes
May 12, 2023
michaelgsharp
commented
May 12, 2023
| @@ -4,6 +4,7 @@ | |||
| <TargetFrameworks>netstandard2.0</TargetFrameworks> | |||
| <IncludeBuildOutput Condition="'$(TargetFramework)' == 'netstandard2.0'">false</IncludeBuildOutput> | |||
| <PackageLicenseFile>LICENSE.txt</PackageLicenseFile> | |||
| <PackageLicenseExpression></PackageLicenseExpression> | |||
There was a problem hiding this comment.
The MKL redist has a different license so we have to blank the PackageLicenseExpression for it to work correctly.
| @@ -4,6 +4,7 @@ | |||
| <TargetFrameworks>netstandard2.0</TargetFrameworks> | |||
| <IncludeBuildOutput Condition="'$(TargetFramework)' == 'netstandard2.0'">false</IncludeBuildOutput> | |||
| <PackageLicenseFile>LICENSE.txt</PackageLicenseFile> | |||
| <PackageLicenseExpression></PackageLicenseExpression> | |||
There was a problem hiding this comment.
This package is not MIT licence ?
There was a problem hiding this comment.
Nope. This package is actually code from Intel that we are compiling to remove the code we don't need (reduces the size by a LARGE amount. Like 90% or so). So its one of Intel's licenses and not MIT. Only package we have that is different like this.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6674 +/- ##
=======================================
Coverage 68.77% 68.77%
=======================================
Files 1215 1215
Lines 251556 251556
Branches 26228 26228
=======================================
+ Hits 173004 173009 +5
+ Misses 71737 71726 -11
- Partials 6815 6821 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed packages to use LicenseExpression instead of LicenseFile.