Micro benchmark fixes #12178
Merged
Micro benchmark fixes #12178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hey there @adamsitnik! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| @@ -67,20 +53,4 @@ static bool Run() | |||
| } | |||
| return success; | |||
| } | |||
|
|
|||
| // NOTE: the built-in ConsoleLogger throws PlatformNotSupportedException | |||
| class Logger : ILogger | |||
There was a problem hiding this comment.
Was there a fix in BDN for the logger? My memory is that some System.Console API threw a PlatformNotSupported exception on Android. I don't remember if I sent a PR for it.
If you ran this on Android and it worked, we're good. I think it threw immediately when benchmarks started.
jonathanpeppers
approved these changes
Dec 19, 2022
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
mattleibow
approved these changes
Feb 1, 2023
Eilon
added
the
t/perf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues reported offline by @fanyang-mono , requires a BenchmarkDotNet update (dotnet/BenchmarkDotNet#2231)