Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effects #1574

Merged
merged 10 commits into from
Jul 12, 2021
Merged

Effects #1574

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using Microsoft.Maui.Controls.Compatibility.ControlGallery.Android;
using Microsoft.Maui.Controls.Compatibility.ControlGallery.Effects;
using Microsoft.Maui.Controls.Compatibility.Platform.Android;
using Microsoft.Maui.Controls.Platform;

[assembly: ExportEffect(typeof(AttachedStateEffectRenderer), AttachedStateEffect.EffectName)]
namespace Microsoft.Maui.Controls.Compatibility.ControlGallery.Android
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Microsoft.Maui.Controls.Compatibility.Platform.Android;
using Microsoft.Maui.Controls.Platform;

namespace Microsoft.Maui.Controls.Compatibility.ControlGallery.Android
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using Microsoft.Maui.Controls.Compatibility.Platform.Android;
using AndroidX.Core.View;
using AndroidX.Core.View.Accessibility;
using Microsoft.Maui.Controls.Platform;

[assembly: ExportEffect(typeof(ContentDescriptionEffectRenderer), ContentDescriptionEffect.EffectName)]
namespace Microsoft.Maui.Controls.Compatibility.ControlGallery.Android
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using Microsoft.Maui.Controls.Internals;
using Microsoft.Maui.Controls.Compatibility.Platform.Android;
using AView = Android.Views.View;
using Microsoft.Maui.Controls.Platform;

[assembly: ExportEffect(typeof(Microsoft.Maui.Controls.Compatibility.ControlGallery.Android.RippleEffect), nameof(Microsoft.Maui.Controls.Compatibility.ControlGallery.Android.RippleEffect))]
namespace Microsoft.Maui.Controls.Compatibility.ControlGallery.Android
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using Microsoft.Maui.Controls;
using Microsoft.Maui.Controls.Compatibility.ControlGallery.Issues;
using Microsoft.Maui.Controls.Compatibility.Platform.Android;
using Microsoft.Maui.Controls.Platform;

[assembly: ExportEffect(typeof(Microsoft.Maui.Controls.Compatibility.ControlGallery.Android._58406EffectRenderer), Bugzilla58406.EffectName)]

Expand Down
4 changes: 4 additions & 0 deletions src/Compatibility/ControlGallery/src/Core/Startup.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ public virtual void Configure(IAppHostBuilder appBuilder)
.ConfigureServices(services =>
{
DependencyService.Register(Device.GetAssemblies());
})
.ConfigureEffects(effects =>
{
effects.AddCompatibilityEffects(Device.GetAssemblies());
});
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/Compatibility/ControlGallery/src/WinUI/App.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ public App()
InitializeComponent();
}

protected override IStartup OnCreateStartup() => new Startup();
protected override IStartup OnCreateStartup() => new WinUIStartup();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using Microsoft.Maui.Controls.Compatibility.ControlGallery.Effects;
using Microsoft.Maui.Controls.Compatibility.ControlGallery.WinUI;
using Microsoft.Maui.Controls.Compatibility.Platform.UWP;
using Microsoft.Maui.Controls.Platform;

[assembly: ExportEffect(typeof(AttachedStateEffectRenderer), AttachedStateEffect.EffectName)]
namespace Microsoft.Maui.Controls.Compatibility.ControlGallery.WinUI
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using Microsoft.Maui.Controls;
using Microsoft.Maui.Controls.Compatibility.ControlGallery.WinUI;
using Microsoft.Maui.Controls.Compatibility.Platform.UWP;
using Microsoft.Maui.Controls.Platform;
using Microsoft.UI.Xaml.Controls;
using Microsoft.UI.Xaml.Media;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
using Microsoft.Maui.Controls;
using Microsoft.Maui.Controls.Compatibility.ControlGallery.WinUI;
using Microsoft.Maui.Controls.Compatibility.Platform.UWP;
using Microsoft.Maui.Controls.Platform;
using Microsoft.UI;
using Microsoft.UI.Xaml.Media;
using Windows.UI;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using Microsoft.Maui.Controls;
using Microsoft.Maui.Controls.Compatibility.ControlGallery.Issues;
using Microsoft.Maui.Controls.Compatibility.Platform.UWP;
using Microsoft.Maui.Controls.Platform;
using Microsoft.UI.Xaml.Controls;

[assembly: ExportEffect(typeof(Microsoft.Maui.Controls.Compatibility.ControlGallery.WinUI._58406EffectRenderer), Bugzilla58406.EffectName)]
Expand Down
1 change: 1 addition & 0 deletions src/Compatibility/ControlGallery/src/iOS/AppDelegate.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
using Microsoft.Maui.Controls.Compatibility.ControlGallery;
using Microsoft.Maui.Controls.Compatibility.Platform.iOS;
using Size = Microsoft.Maui.Graphics.Size;
using Microsoft.Maui.Controls.Platform;

[assembly: Dependency(typeof(TestCloudService))]
[assembly: Dependency(typeof(CacheService))]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using Microsoft.Maui.Controls.Compatibility.ControlGallery.Effects;
using Microsoft.Maui.Controls.Compatibility;
using Microsoft.Maui.Controls.Compatibility.Platform.iOS;
using Microsoft.Maui.Controls.Platform;

[assembly: ExportEffect(typeof(AttachedStateEffectRenderer), AttachedStateEffect.EffectName)]
namespace Microsoft.Maui.Controls.Compatibility.ControlGallery.iOS
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using Microsoft.Maui.Controls;
using Microsoft.Maui.Controls.Compatibility.Platform.iOS;
using Microsoft.Maui.Controls.Platform;

[assembly: ExportEffect(typeof(Microsoft.Maui.Controls.Compatibility.ControlGallery.iOS.CustomEffects.FooEffect), nameof(Microsoft.Maui.Controls.Compatibility.ControlGallery.iOS.CustomEffects.FooEffect))]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using Microsoft.Maui.Controls.Compatibility.ControlGallery.iOS;
using Microsoft.Maui.Controls.Compatibility.ControlGallery.Issues;
using Microsoft.Maui.Controls.Compatibility.Platform.iOS;
using Microsoft.Maui.Controls.Platform;

[assembly: ExportEffect(typeof(GradientEffect), Issue6334.EffectName)]
namespace Microsoft.Maui.Controls.Compatibility.ControlGallery.iOS
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using Microsoft.Maui.Controls.Compatibility;
using Microsoft.Maui.Controls.Compatibility.Platform.iOS;
using Microsoft.Maui.Graphics;
using Microsoft.Maui.Controls.Platform;

[assembly: ExportEffect(typeof(SearchbarEffect), "SearchbarEffect")]
namespace Microsoft.Maui.Controls.Compatibility.ControlGallery.iOS
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using Microsoft.Maui.Controls.Compatibility.ControlGallery.Issues;
using Microsoft.Maui.Controls.Compatibility;
using Microsoft.Maui.Controls.Compatibility.Platform.iOS;
using Microsoft.Maui.Controls.Platform;

[assembly: ExportEffect(typeof(Microsoft.Maui.Controls.Compatibility.ControlGallery.iOS._58406EffectRenderer), Bugzilla58406.EffectName)]

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Android.Views;
using Microsoft.Maui.Controls.Platform;
using AView = Android.Views.View;

namespace Microsoft.Maui.Controls.Compatibility.Platform.Android.FastRenderers
Expand Down Expand Up @@ -28,8 +29,8 @@ public void RegisterEffect(Effect effect)
return;
}

platformEffect.SetControl(_control);
platformEffect.SetContainer(_container);
platformEffect.Container = _container;
platformEffect.Control = _control;
}
}
}
10 changes: 0 additions & 10 deletions src/Compatibility/Core/src/Android/PlatformEffect.cs

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,8 @@ void IEffectControlProvider.RegisterEffect(Effect effect)

void OnRegisterEffect(PlatformEffect effect)
{
effect.SetContainer(this);
effect.SetControl(this);
effect.Container = this;
effect.Control = this;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@ void IEffectControlProvider.RegisterEffect(Effect effect)

void OnRegisterEffect(PlatformEffect effect)
{
effect.SetContainer(this);
effect.SetControl(this);
effect.Container = this;
effect.Control = this;
}

static int GetDistance(double start, double position, double v)
Expand Down
2 changes: 1 addition & 1 deletion src/Compatibility/Core/src/Android/ViewRenderer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ protected override void OnLayout(bool changed, int l, int t, int r, int b)
protected override void OnRegisterEffect(PlatformEffect effect)
{
base.OnRegisterEffect(effect);
effect.SetControl(Control);
effect.Control = Control;
}

void SetupAutomationDefaults()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ void UpdateParentPageTraversalOrder()

protected virtual void OnRegisterEffect(PlatformEffect effect)
{
effect.SetContainer(this);
effect.Container = this;
}

void SetupAutomationDefaults()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using Microsoft.Maui.Controls.Hosting;
using Microsoft.Maui.Hosting;

namespace Microsoft.Maui.Controls.Compatibility
Expand Down Expand Up @@ -101,5 +102,13 @@ public static IImageSourceServiceCollection AddCompatibilityServices(this IImage
#endif
return services;
}



public static IEffectsBuilder AddCompatibilityEffects(this IEffectsBuilder effectsBuilder, params global::System.Reflection.Assembly[] assemblies)
{
Internals.Registrar.RegisterEffects(assemblies);
return effectsBuilder;
}
}
}
8 changes: 0 additions & 8 deletions src/Compatibility/Core/src/WinUI/PlatformEffect.cs

This file was deleted.

5 changes: 3 additions & 2 deletions src/Compatibility/Core/src/WinUI/VisualElementRenderer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -397,10 +397,11 @@ protected virtual void OnElementPropertyChanged(object sender, PropertyChangedEv

protected virtual void OnRegisterEffect(PlatformEffect effect)
{
effect.SetContainer(this);
effect.SetControl(Control);
effect.Container = this;
effect.Control = Control;
}


protected virtual void SetAutomationId(string id)
{
this.SetAutomationPropertiesAutomationId(id);
Expand Down
13 changes: 0 additions & 13 deletions src/Compatibility/Core/src/iOS/PlatformEffect.cs

This file was deleted.

1 change: 1 addition & 0 deletions src/Compatibility/Core/src/iOS/ShadowEffect.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System;
using System.ComponentModel;
using Microsoft.Maui.Controls.Internals;
using Microsoft.Maui.Controls.Platform;
using Microsoft.Maui.Graphics;
using UIKit;
using PlatformElement = Microsoft.Maui.Controls.PlatformConfiguration.iOSSpecific.VisualElement;
Expand Down
2 changes: 1 addition & 1 deletion src/Compatibility/Core/src/iOS/ViewRenderer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ protected override void OnElementPropertyChanged(object sender, PropertyChangedE
protected override void OnRegisterEffect(PlatformEffect effect)
{
base.OnRegisterEffect(effect);
effect.SetControl(Control);
effect.Control = Control;
}

protected override void SetAccessibilityHint()
Expand Down
6 changes: 3 additions & 3 deletions src/Compatibility/Core/src/iOS/VisualElementRenderer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ public static void RegisterEffect(Effect effect, NativeView container, NativeVie
if (platformEffect == null)
return;

platformEffect.SetContainer(container);
platformEffect.SetControl(control);
platformEffect.Container = container;
platformEffect.Control = control;
}

#if __MOBILE__
Expand Down Expand Up @@ -445,7 +445,7 @@ protected virtual void OnElementPropertyChanged(object sender, PropertyChangedEv

protected virtual void OnRegisterEffect(PlatformEffect effect)
{
effect.SetContainer(this);
effect.Container = this;
}

protected virtual void SetAccessibilityHint()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
<MauiSplashScreen Include="Resources\Images\dotnet_bot.svg" Color="#FFFFFF" />
<AndroidResource Remove="Resources\**" />
</ItemGroup>

<Import Condition=" '$(UseMaui)' != 'true' " Project="..\..\..\BlazorWebView\src\Maui\build\Microsoft.AspNetCore.Components.WebView.Maui.targets" />

</Project>
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?xml version="1.0" encoding="utf-8" ?>
<views:BasePage
xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
x:Class="Maui.Controls.Sample.Pages.EffectsPage"
xmlns:views="clr-namespace:Maui.Controls.Sample.Pages.Base"
xmlns:local="clr-namespace:Maui.Controls.Sample.Pages"
Title="Alerts">
<views:BasePage.Content>
<StackLayout
Margin="12">
<Label
Text="Entry With Focus Routing Effect"
Style="{StaticResource Headline}"/>
<Entry
Text="Alert Simple">
<Entry.Effects>
<local:FocusRoutingEffect></local:FocusRoutingEffect>
</Entry.Effects>
</Entry>
<Label
Text="Entry With Focus Platform Effect"
Style="{StaticResource Headline}"/>
<Entry
Text="Alert Simple">
<Entry.Effects>
<local:FocusPlatformEffect></local:FocusPlatformEffect>
</Entry.Effects>
</Entry>
</StackLayout>
</views:BasePage.Content>
</views:BasePage>
Loading