Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove left over Platform Effect from WinUI compatibility #1696

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Remove left over Platform Effect from WinUI compatibility #1696

merged 1 commit into from
Jul 15, 2021

Conversation

PureWeen
Copy link
Member

Description of Change

PlatformEffects were all deleted from compatibility but this one for some reason survived

@PureWeen PureWeen requested a review from rachelkang July 15, 2021 21:45
rachelkang
rachelkang approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great now!!

@PureWeen PureWeen merged commit fba6a03 into main Jul 15, 2021
@PureWeen PureWeen deleted the remove_left_over_platformeffect branch July 15, 2021 22:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rachelkang rachelkang rachelkang approved these changes

Assignees
No one assigned
Labels
fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3! platform/windows 🪟
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PureWeen @rachelkang @samhouts