Remove a few allocations from GridLengthTypeConverter
#22095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartyIX
force-pushed
the
feature/2024-04-27-GridLengthTypeConverter-perf
branch
2 times, most recently
from
4095fab
to
8f5cd2f
Compare
MartyIX
force-pushed
the
feature/2024-04-27-GridLengthTypeConverter-perf
branch
from
8f5cd2f
to
aa2c8fe
Compare
MartyIX
commented
Apr 27, 2024
| return new GridLength(1, GridUnitType.Star); | ||
| } | ||
|
|
||
| #if NETSTANDARD2_0_OR_GREATER |
There was a problem hiding this comment.
Is this "too much"?
|
see my existing PR here: #20048 |
|
It only affects things on the order of microseconds. Allocations are improved, though. |
|
I see. |
Eilon
added
t/perf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Use Spans to avoid allocations.
I don't believe this will have any significant effect though.
Issues Fixed
Contributes to #21787