Improve MauiFactory performance by avoiding reflection to get base classes #24775
+18
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
A minor improvement to a piece of code executed on every
ToHandler
orToPlatform
.Speedscope Before
Speedscope After
Extra note
I had some code ready to cache the entire
Type
=>ServiceDescriptor(s)
and make this even faster, but it breaks a unit test which honestly I don't understand the purpose of:maui/src/Core/tests/UnitTests/Hosting/HostBuilderHandlerTests.cs
Lines 86 to 99 in 3de5be9