Speed-up Border rendering by avoiding useless pass during size allocation #24844
+26
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
While updating the frame from
Handler
we setWidth
andHeight
.Each of them triggers border mapping:
The first one is useless as the other dimension will change right after.
We can avoid this by batching the change on
SizeAllocated
:maui/src/Controls/src/Core/VisualElement/VisualElement.cs
Lines 1718 to 1733 in 4b8e604
This brings us to a better result:
Issues Fixed
Fixes #24843
Contributes to #24123