Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/startup di #529

Merged
merged 7 commits into from
Mar 18, 2021
Merged

Dev/startup di #529

merged 7 commits into from
Mar 18, 2021

Conversation

mattleibow
Copy link
Member

Description of Change

This PR is sort of working on from #436 and moves away from a static Current in the app and just keeps that for the actual running app.

I know that we are going to get proper IMauiContext going with the views, but I wanted to start moving away from the static and use the context that we already know about when fetching the handler. We can then tell the handler which context to use by just setting it on the handler itself. This is also nice for Android as the MauiContext also contains the Android Context as well as the services and whatever else.

Another change I made in the main entrypoint classs is to not require 2 generic parameters (Startup and App) but rather just the Startup (in hopes that we can actually generate this code) and then add a new extension to the builder to specify the app class .UseMauiApp<MyApp>(). Not only does this make all the init code in one place, but this can be changed at runtime if needed.

One big benefit of moving the Current property up one level is that unit testing Core is now easy because the App type is no longer a singleton-only system and each test can totally customise it without impacting others. MauiApp still has the Current property, but this is not used really. I would love to say that we should remove it altogether, but this might be too crazy for developers coming from Forms as they will be used to some sort of "current app". However, if we wish to entertain the idea, then we can remove it and it will be very simple for each dev out there to add a Current property on their app type.

Oh yeah, and constructor DI is working for some reason. Check the changes I made to the sample types... No idea why it is working now or if maybe we just hadn't set up things in the past and at some point it started working.

@mattleibow mattleibow mentioned this pull request Mar 17, 2021
Merged
@Codelisk
Copy link

I would love to say that we should remove it altogether, but this might be too crazy for developers coming from Forms

I am all for it!

rmarinho
rmarinho reviewed Mar 17, 2021
View reviewed changes
src/Compatibility/Core/src/Android/AppCompat/Platform.cs
@@ -313,6 +313,7 @@ internal static IVisualElementRenderer CreateRenderer(VisualElement element, Con
try
{
handler = Forms.MauiContext.Handlers.GetHandler(element.GetType());
handler.SetMauiContext(Forms.MauiContext);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have doubts if we should't move this to IFrameworkElement

rmarinho
rmarinho reviewed Mar 17, 2021
View reviewed changes
src/Controls/src/Core/HandlerImpl/SearchBar.Impl.cs
@@ -0,0 +1,6 @@
namespace Microsoft.Maui.Controls
{
public partial class SearchBar : ISearchBar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you adding this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the SearchBar PR did not add this or register it with the handlers. Seems I missed that when reviewing the PR. Without this it actually throes so I am not even sure how it ran locally...

@rmarinho
Copy link
Member

The ctor injection is working because you are using the Microsoft.Extensions.DependencyInjection ServiceCollection, not the Maui one.

We have tested some of the approach you have here, and the issue is a increase on startup time, not much irc, was around 10ms to register the App and then get the app , take not that as more things are registered on the container it would also increase the time of startup because the ServiceCollection would have more stuff.

I do like the changes of moving away from static instance. One of the other things would be nice we try to solve is how we could register the IServiceProvider, so in the MauiApp ctor, if the user wants it could request it and have access to it. right now it's only possible after the OnCreate where we do the SetServiceProvider.

@mattleibow mattleibow merged commit f9b38a6 into startup Mar 18, 2021
@mattleibow mattleibow deleted the dev/startup-di branch March 18, 2021 02:54
myroot added a commit to myroot/maui that referenced this pull request Aug 24, 2022
@myroot @rookiejava
@JoonghyunCho @sung-su @shyunMin
Replace Tizen Backend engine
0e0802e 
* Remove comment

* Remove image resource on Tizen project

* Remove space

* Fix compatibility issue (#41)

* Fix compatibility issue

* Fix Compatibility Resource path

* Bump to latest

- Modal Navigation Manager (dotnet#1563)
- Implement the basic WindowHandler (dotnet#1468)
- Don't extract native defaults, meaning users can no longer reset a color back to a platform theme (dotnet#1485)
- Implement Alerts (Alert, Prompt and ActionSheet) (dotnet#1328)
- And so on.

* [SingleProject] Fix Issues (#50)

* Bumt to latest

- Effects (dotnet#1574)
- Improve Window and AnimationManager (dotnet#1653)
- and so on

* Add Microsoft.Maui.Graphics.Skia as PackageReference

* Add Essentials.Samples.Tizen (#24)

* Add Essentials.Samples.Tizen

* Add guard for null exception

* Fix Essentials.Samples for Tizen

* Fix csproj for net6

* Remove Forms.Init

* Fix build error (#60)

* Update referenced Tizen.UIExtensions version (#61)

* Add BlazorWebView skeleton code (#62)

* Bump to latest (#71)

- Window lifecycle (dotnet#1754)
- Move New Navigation Handler to Core and make it internal (dotnet#1800)
- Scrollview handler (dotnet#1669)
- ScrollView Resize + Window Handler Resize (dotnet#1676)
- Font AutoScalingEnabled (dotnet#1774)
- Rename Font Properties (dotnet#1755)
- Update layout system to ensure native measure/arrange are called for all controls, even from Page subclasses (dotnet#1819)
- IContainer as IList<IView> (dotnet#1724)
- Implement Layout padding for new StackLayouts and GridLayout (dotnet#1749)
- Delete all the TabIndex, TabStop, Focusable things! (dotnet#1777)
- Introduce SetSemanticFocus API via SemanticExtensions (dotnet#1829)
- Improve Window and AnimationManager (dotnet#1653)
- And so on

* Remove IPage on Tizen (#72)

- Merge IFrameworkElement and IView and Remove IPage (dotnet#1875)

* Add Blazor webview (#67)

* Add Blazor webview

* Replace space to tab

* remove space

* Fix entry cursor error (#68)

* Fix entry cursor error

* Update code referring to android extension

* Remove duplicate code & Add exception cases

* Code fixes for consistency

* Fix nullable issue (#77)

* Fix Image loading (#78)

* Fix nested layout issue (#79)

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <[email protected]>

* Fix issues caused by bump up (#75)

* Fix issues caused by bump up

* Update Tizen file provider

* Update file provider with proper path

* Fix unmatched partial method (#84)

* Fixes incorrect parameter type for ILayoutManager.ArrangeChildren (Rectangle -> Size). (#91)

* Make the HandlerToRendererShim simple

* Revert "Fixes incorrect parameter type for ILayoutManager.ArrangeChildren (Rectangle -> Size). (#91)" (#97)

This reverts commit c54ac83.

* Refactor the LayoutHandler (#99)

* Fix layout measure issue (#100)

* Fix LayoutHandler Update issue (#103)

* Fix LayoutHandler Update issue

* Implement InvalidateMeasure propagation

* Update MapBackground

* Add InitializationOptions (#107)

* Add InitializationOptions

* Set UseSkiaSharp true as default

* Apply DP as default

* Fix SKClipperView to have proper size (#115)

* Fix Essentials sample (#108)

* Fix Essentials sample for Tizen

* Remove UseSkiaSharp flag

* Remove MaterialComponents

* Fix Tizen flag

* Remove CustomRenderer

* Add ShellHandler (#64)

* Add ShellHandler

* Move ShellView into Platform/Tizen

* Update ShellView

* Move the code for embedded tizen resources to csproj

* Add UIExtenstions for shell

* MAUI workload for Tizen (#66)

* Fix build and runtime error after bumping to latest code

* Fix HandlerToRendererShim dispose (dotnet#127)

* Add ShellSearchView (#121)

* Add ShellSearchView

* Fix the layout issue in ShellSearchResultList

* Enable nullable

* Fix maximum height of ShellSearchResultList

* Fix scaling issue on Clip (dotnet#130)

* Fix DisplayResolutionUnit sync issue (dotnet#134)

* Fix build error (dotnet#137)

* Replace SkiaGraphicsView with local patch (dotnet#135)

This commit will be revert when upstream code is updated

* Support Min/Max Height/Width on IView and applying MauiApp/MauiAppBuilder pattern

- Support Min/Max Height/Width on IView (dotnet#2265)
- Updating .NET MAUI to use MauiApp/MauiAppBuilder pattern and use MS.Extensions.DependencyInjection (dotnet#2137)

* Fix Tizen Templates (dotnet#144)

* Fix webview break caused by updated dependency (dotnet#143)

* Update the Tizen.UIExtension.ElmSharp version (dotnet#145)

* Reomve internal UIExtensions compoments for Shell (dotnet#147)

* Adds missing implementation after bumping to latest main

* [Tizen] Adds BoxView Handler

* [Tizen] Implement ProgressColor property in ProgressBarHandlers

- Implement ProgressColor property in ProgressBarHandlers (dotnet#600)

* [Tizen] Handle ContentViews and templated content in new layout system

* Bump to latest (rc1)

- ImageButtonHandler and Handler Re-usability (dotnet#2352)
- Remove IBoxView (dotnet#2619)
- Add SupportedOSPlatformVersion (dotnet#2565)
- Merge all the .NET 6 projects/solutions (dotnet#2505)
- Shadow Support (dotnet#570)
- Add IndicatorView handler(dotnet#2038)

* [Tizen] Apply graphics related code review feedback

* [Tizen] Port H/V TextAlignment to Editor/Picker Handler

* [Tizen] Add TVShellView (dotnet#183)

* [Tizen] Add TVShellView

* [Tizen] Update TVShellView

* [Tizen] Update NativeView for Shell

* [Tizen] Update ShellView

* [Tizen] Change default FlyoutBackgroundColor for TV

* [Tizen] Enable nullable

* Refactor WrapperView to draw drawable features (dotnet#186)

* Refactor WrapperView to draw drawable features

* Update class names and devide files

* Override NeesContainer to remove duplicated code

* Update class names

* [Tizen] Adds ApplicationHandler

* Fix Background issue of Frame (dotnet#193)

* Fix UpdateBackground (dotnet#194)

* Fix UpdateBackground

* Add ContentView Background mapper

* Fix Editor/Entry/Label/Layout Background

* Add IWrapperViewCanvas.Content

* Add PageHandler Background mapper

* Restore WrapperView

* Remove unnecessary namespace

* [Tizen] Fix build error on PageHandler

* [Tizen] Apply ITextButton related changes

* [Tizen] Add Shadows (dotnet#233)

* [Tizen] Add Shadows

* [Tizen] Apply review comments

* [Tizen] Move updating shape in proper position

* [Tizen] Update BackgroundDrawable

* [Tizen] Apply review comments

* [Tizen] Add BorderDrawable (dotnet#224)

* Move to platform specific

* Fix border handler for Tizen

* Rename ToDrawable method

* Fix border content layout

* Fix BorderView

* Apply rebase

* [Tizen] Fix entry cursor issue (dotnet#222)

* Fix entry cursor issue

* Fix UpdateSelectionLength method

* [Tizen] Remove TVNavigationDrawer TVNavigationView (dotnet#223)

* [Tizen] Remove TVNavigationDrawer TVNavigationView

* [Elmsharp] Update Tizen.UIExtensions version

* [Tizen] Initial Multi Window support

* [Tizen] Fix MauiContext

* [Tizen] Refactor Border by defining MauiDrawable (dotnet#248)

* [Tizen] Refactor Border by defining MauiDrawable

* [Tizen] Apply review comments

* [Tizen] Remove unnecessary type casting

* [Tizen] Move getting path logic to drawable

* [Tizen] Obsolete AndExpand & Remove IsolatedStorage

* Fix tizen solution (.sln) correctly

* [Tizen] Add VerticalTextAlignment

* [Tizen] Fix Scoping of MauiContext

* [Tizen] Use CoreApplication as native app type

* [Tizen] Applying upstream changes

* [Tizen] Add ContainerView to Layout if it's present

* [Tizen] Initial Reloadyfy support

* [Tizen] Initial IVisualDiagnosticOveraly support

* [Tizen] Move types in the Platform folder into the Platform namespaces

* Fix CollectionView layout issue (dotnet#288)

* Fix CollectionView layout issue

* Remove unnecessary code

* [Tizen] ZIndex proof-of-concept

* Fix ScrollView ContentSize and Padding margin (dotnet#291)

* Fix ScrollView ContentSize and Padding margin

* Fix MapRequestScrollTo

* Update src/Core/src/Handlers/ScrollView/ScrollViewHandler.Tizen.cs

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <[email protected]>

* Update src/Core/src/Handlers/ScrollView/ScrollViewHandler.Tizen.cs

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <[email protected]>

* Remove MapContentSize

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <[email protected]>

* Implements WindowOverlay and VisualDiagnosticsOverlay (dotnet#294)

* Implements WindowOverlay and VisualDiagnosticsOverlay

* Apply code review

* [Tizen] Fix Image Handler

* Remove GetDesiredSize (dotnet#295)

* [Tizen] Fix ButtonHandler

* [Tizen] Organize and centralize HandlerExtensions

* Refactor WrapperView and Fix Issue (dotnet#302)

* Refactor WrapperView

* Use Thickness type for Shadow margin

* Update variable name

* Update class name to GraphicsExtensions

* Fix essentials sample for Tizen (dotnet#305)

* [Tizen] Fix NativeView casting issue

* Fix BlazorWebview binary resource issue (dotnet#317)

* [Tizen] Handle query strings in Blazor static assets by trimming them out

* Refactor MauiContext (dotnet#330)

* [Tizen] Adds PaintExtensions

* [Tizen] Implement CursorPosition in IEditor/ITextInput Handlers

* [Tizen] Remove GetNative

* [Tizen] Update Microsoft.NET.Sdk.Maui/WorkloadManifest

* [Tizen] Bump to latest

* [Tizen] Use legacy compat renderers temporarily

* [Tizen] Implement IPlatformApplication.Current

* [Tizen] Fix INativeViewHandler to return more expected NativeView

* [Tizen] Remove legacy TFMs

* [Tizen] Remove `IPlatformInvalidate` and `Device.Invalidate()

* [Tizen] Fix Essential sample build error

* [Tizen] Refactor Essential's implementations

* [Tizen] Renaming public APIs Native -> Platform

* [Tizen] Interfaced Handler for Label, Page, NavigationView, Picker,
ProgressBar, SwipeView

* [Tizen] Moved GetPlatformSize logic into a new service

* [Tizen] Interfaced handler for Switch, TimePicker, WebView, Slider,
SearchBar, RefreshView, RadioButton

* [Tizen] Fix build error after rebasing

* [Tizen] Move TabbedPageHandler to TabbedViewHandler

* [Tizen] Backport p14 changes

* [Tizen] Loaded/Unloaded events and propagate Window

* [Tizen] Implement FillRule property in Polygon/PolylineHandler

* [Tizen] Add install tizen to provision.yml

* [Tizen] Move package version into Versions.props

* Adds the Tizen backend

* [Tizen] Add Resizetizer Tizen Implementation

* Bump to latest and fix build error

* Bump to latest

- Apply to start adding in APIs for adding legacy renderers via assembly scanning (dotnet#1333)
- Update to IMauiContext (dotnet#1357)
- and so on

* Bump to latest

- Apply to patch related to Animation (dotnet#1436)
- Apply to register Microsoft.Maui.Graphics Platforms (dotnet#1441)
- and so on.

* Bump to latest

- Modal Navigation Manager (dotnet#1563)
- Implement the basic WindowHandler (dotnet#1468)
- Don't extract native defaults, meaning users can no longer reset a color back to a platform theme (dotnet#1485)
- Implement Alerts (Alert, Prompt and ActionSheet) (dotnet#1328)
- And so on.

* Bumt to latest

- Effects (dotnet#1574)
- Improve Window and AnimationManager (dotnet#1653)
- and so on

* Fix build error (#60)

* Bump to latest (#71)

- Window lifecycle (dotnet#1754)
- Move New Navigation Handler to Core and make it internal (dotnet#1800)
- Scrollview handler (dotnet#1669)
- ScrollView Resize + Window Handler Resize (dotnet#1676)
- Font AutoScalingEnabled (dotnet#1774)
- Rename Font Properties (dotnet#1755)
- Update layout system to ensure native measure/arrange are called for all controls, even from Page subclasses (dotnet#1819)
- IContainer as IList<IView> (dotnet#1724)
- Implement Layout padding for new StackLayouts and GridLayout (dotnet#1749)
- Delete all the TabIndex, TabStop, Focusable things! (dotnet#1777)
- Introduce SetSemanticFocus API via SemanticExtensions (dotnet#1829)
- Improve Window and AnimationManager (dotnet#1653)
- And so on

* Bump to latest

* Fix Essentials sample (#108)

* Fix Essentials sample for Tizen

* Remove UseSkiaSharp flag

* Remove MaterialComponents

* Fix Tizen flag

* Remove CustomRenderer

* Add ShellHandler (#64)

* Add ShellHandler

* Move ShellView into Platform/Tizen

* Update ShellView

* Move the code for embedded tizen resources to csproj

* Add UIExtenstions for shell

* MAUI workload for Tizen (#66)

* Fix build and runtime error after bumping to latest code

* Fix Essentials (dotnet#146)

* Fix Essentials sample for tizen

* Add SemanticScreenReader for Tizen

* Fix Startup

* Adds missing implementation after bumping to latest main

* Bump to latest (rc1)

- ImageButtonHandler and Handler Re-usability (dotnet#2352)
- Remove IBoxView (dotnet#2619)
- Add SupportedOSPlatformVersion (dotnet#2565)
- Merge all the .NET 6 projects/solutions (dotnet#2505)
- Shadow Support (dotnet#570)
- Add IndicatorView handler(dotnet#2038)

* Refactor WrapperView to draw drawable features (dotnet#186)

* Refactor WrapperView to draw drawable features

* Update class names and devide files

* Override NeesContainer to remove duplicated code

* Update class names

* [Tizen] Adds ApplicationHandler

* Fix UpdateBackground (dotnet#194)

* Fix UpdateBackground

* Add ContentView Background mapper

* Fix Editor/Entry/Label/Layout Background

* Add IWrapperViewCanvas.Content

* Add PageHandler Background mapper

* Restore WrapperView

* Remove unnecessary namespace

* [Tizen] Add BorderDrawable (dotnet#224)

* Move to platform specific

* Fix border handler for Tizen

* Rename ToDrawable method

* Fix border content layout

* Fix BorderView

* Apply rebase

* [Tizen] Refactor Border by defining MauiDrawable (dotnet#248)

* [Tizen] Refactor Border by defining MauiDrawable

* [Tizen] Apply review comments

* [Tizen] Remove unnecessary type casting

* [Tizen] Move getting path logic to drawable

* [Tizen] Fix Scoping of MauiContext

* [Tizen] Applying upstream changes

* [Tizen] Move types in the Platform folder into the Platform namespaces

* [Tizen] Fix ButtonHandler

* [Tizen] Organize and centralize HandlerExtensions

* Refactor MauiContext (dotnet#330)

* Add NUI handler

* [Tizen] Refactor MauiApplication and MauiContext (dotnet#216)

* Add AlertManager (dotnet#214)

* Code clean up (dotnet#218)

* Fix build error on Controls.Sample (dotnet#225)

* [Tizen] Initail CollectionViewHandler for NUI

* Fix PlatformEffect NativeView type (dotnet#231)

* Fix Control.Sample correctly (dotnet#234)

* Fix NamedSize (dotnet#242)

* Update NavigationPageRenderer (dotnet#238)

- Implement title view

* Fix build errors and apply upstream changes

* Refactoring Window and modal (dotnet#246)

* Obsolete AndExpand & fix build eror

* [NUI] Implement BlazorWebView (dotnet#259)

* Implement BlazorWebView

* Update NUI WebView alias name

* Bump to latest

* Fix MinimumWidth/Height MaximumWidth/Height (dotnet#270)

* [NUI] Add GestureManager (dotnet#272)

* Add gesture handler

* enable nullable

* use lazy

* Remove unnessary EFL code in ScrollViewHandler (dotnet#274)

* Add TabbedPage Renderer (dotnet#275)

* [NUI] Implement WrapperView enabling Border and Shadow (dotnet#273)

* [NUI] Add MauiDrawable enabling Border and Shadow

* [NUI] Remove BorderView type and refactor

* Refactor StrokeExtensions

* Remove unnecessary code

* Update a way clearing content

* [NUI] Add Picker handler (dotnet#276)

* Add Picker handler

* Apply code review

* Change timing adding event handler

* Update Picker on touch (dotnet#293)

* Fix NeedsContainer (dotnet#306)

* Update FrameRenderer to support Brush (dotnet#309)

* Fix minor layout issue (dotnet#314)

* Fix build error

* Fix ScrollView ContentSize (dotnet#324)

* Refactor Maui context (dotnet#328)

* Fix build error after bumping to latest

* [Tizen] Add ImageButtonHandler (dotnet#334)

* [NUI] Implement Editor/Entry handler (dotnet#335)

* Implement Editor/Entry handler

* Fix measure issue

* Update paramer name

* Fix if statement

* Fix Editor/Entry CursorPosition issue (dotnet#336)

* [NUI] Add CollectionViewHandler (dotnet#352)

* Fix EmptyView on CollectionView

* Add CollectionViewHandler

* Add SearchBar handler (dotnet#354)

* Implement Clip (dotnet#384)

* Bump to latest

* [NUI] Add TimePickerHandler (dotnet#390)

* [NUI] Add TimePickerHandler

* Update button placement

* Clean up code after rebase (dotnet#399)

* Fix TabbedPage to use Controls.Grid instead Compatibility.Grid (dotnet#400)

* Fix Controls MapText (dotnet#406)

* Fix focus management (dotnet#407)

* Update WrapperView (dotnet#409)

* Update Tizen platform to tizen10.0 (dotnet#416)

* Update WebView handler and MauiWebView handler (dotnet#417)

* Update Label shadow (dotnet#420)

* Fix build error after rebase

* Fix InputTransparent (dotnet#424)

* Implement CarouselView handler (dotnet#428)

* Fix GestureManager crash issue (dotnet#432)

* Update WebView EvaluateJavaScript async (dotnet#435)

* Fix CascadeInputTransparent (dotnet#442)

* Add NavigationView handler (dotnet#449)

* Update WindowOverlay handler (dotnet#452)

* Update ViewExtensions (dotnet#455)

* Update ImageSourceService (dotnet#454)

* Fix MauiSearchBar IsEnabled property (dotnet#458)

* Add SwipeView handler (dotnet#460)

* Clean code after rebase

* Fix GetPath to return a correct path (dotnet#465)

* Update for focus navigation (dotnet#459)

* Cleanup code after rebase

* Fix build error after rebase

* Implement UpdateBackgroundImageSourceAsync extensions method (dotnet#479)

* [NUI] Update SliderHandler with NUI slider component (dotnet#487)

* Update SliderHandler with NUI compnent

* Update SliderHandler with review feedback

* Update with review feedback

* Fix GetPlatformViewBounds as Pixel coordinate (dotnet#488)

* Fix ScrollView content size update issue (dotnet#492)

* Implement Controls.Compatibility for tizen (dotnet#493)

* Optimize Layout Measure (dotnet#495)

* Code cleanup after code rebase

* Fix z-order on Layout (dotnet#497)

* [NUI] Update StepperHandler (dotnet#498)

* Update StepperHandler

* Apply Review comment

* Fix Frame measure (dotnet#501)

* Fix BorderView (dotnet#500)

* Add RadioButton handler (dotnet#499)

* Fix CollectionView Item measure (dotnet#502)

* Fix Measure contraint convert (dotnet#504)

* Fix WrapperView measure (dotnet#507)

* Implement Missing mapper (dotnet#509)

* Fix WrapperView Width/HeightSpecification (dotnet#510)

* Fix ShapeView (dotnet#511)

* Optimize View measure (dotnet#513)

* Fix NavigationPage disposing pages (dotnet#514)

* Fix build error after rebase

* Fix WebView (dotnet#515)

* Fix TableView (dotnet#516)

* Fix Compatibility Cell templates (dotnet#517)

* [NUI] Add IndicatorViewHandler (dotnet#518)

* Add IndicatorViewHandler

* Update review comment

* Add space

* Fix ListViewRenderer (dotnet#519)

* Fix Binding error on CollectionView (dotnet#520)

* Fix layout issue when view was shown from hide (dotnet#522)

* [NUI] Fix ImageButton Clicked (dotnet#523)

* Fix ImageButton Clicked

* Apply review comment

* Fix BlazorWebView RequestIntercept issue (dotnet#524)

* Fix Layout size issue (dotnet#525)

* Fix build error after rebase

* [NUI] Add DatePicker Handler (dotnet#528)

* Add DatePicker

* Add missing class

* Update Style and Use DummyPopupPage

* Refactoring with MauiTimePicker

* add new file

Co-authored-by: Jay Cho <[email protected]>

* Fix GetBoundingBox/OverlayWindow touch point coordinate to DP (dotnet#529)

* Fix CollectionView EmptyView HeaderFooter (dotnet#530)

* Update DateTimePicker width on horizontal (dotnet#531)

* Fix DisconnectHandler (dotnet#532)

* Update Page default background color (dotnet#533)

* Clean up NuGet.config (dotnet#535)

* [NUI] Update font size (dotnet#536)

* Update FontNamedSize

* adjust font size on tv profile

* Add RefreshViewHandler (dotnet#490)

* [Tizen] Refactor compat renderers (dotnet#538)

* [Tizen] Refactor the TabbedPageRenderer (dotnet#541)

* [Tizen] Add FlyoutViewHandler (dotnet#540)

* Add FlyoutView

* Update FlyoutView to cover TV drawer

* Add missing connecting handler

* Update handler implementation using extensions

* Simplify code

Co-authored-by: Jay Cho <[email protected]>

* [Tizen] Add MauiPicker (dotnet#543)

* Add MenuIcon to Toolbar (dotnet#542)

* Add MenuIcon to Toolbar

* Apply Reviews

Co-authored-by: Jay Cho <[email protected]>

* [Tizen] Add ShellHandler (dotnet#539)

* [NUI] Add ShellHandler

* Update PublicAPI.Shipped.txt file

* Fix build error

* Update AppHostingBuilder

* Update ShellView with review feedback

* Remove unnecessary code

* Update Shell navigation stack

* Add IDisposable interface

* Update ShellSectionView

* Update AdppHostBuilderExtensions

* Rebase and update toolbar to resolve conflict

* Remove ShellContentHandler and update ToolbarHandler

* Update ShellView to handle DrawerToggleVisible

* Remove unnecessary code

* Fix build error after rebase

Co-authored-by: Kangho Hur <[email protected]>
Co-authored-by: 조중현/Common Platform Lab(SR)/Engineer/삼성전자 <[email protected]>
Co-authored-by: 김성수/Common Platform Lab(SR)/Staff Engineer/삼성전자 <[email protected]>
Co-authored-by: 박인서/Common Platform Lab(SR)/Associate/삼성전자 <[email protected]>
Co-authored-by: 민성현/Common Platform Lab(SR)/Staff Engineer/삼성전자 <[email protected]>
Co-authored-by: Jay Cho <[email protected]>
myroot added a commit to myroot/maui that referenced this pull request Aug 24, 2022
@myroot @rookiejava
@JoonghyunCho @sung-su @shyunMin
Replace Tizen Backend engine
b2d674a 
* Remove comment

* Remove image resource on Tizen project

* Remove space

* Fix compatibility issue (#41)

* Fix compatibility issue

* Fix Compatibility Resource path

* Bump to latest

- Modal Navigation Manager (dotnet#1563)
- Implement the basic WindowHandler (dotnet#1468)
- Don't extract native defaults, meaning users can no longer reset a color back to a platform theme (dotnet#1485)
- Implement Alerts (Alert, Prompt and ActionSheet) (dotnet#1328)
- And so on.

* [SingleProject] Fix Issues (#50)

* Bumt to latest

- Effects (dotnet#1574)
- Improve Window and AnimationManager (dotnet#1653)
- and so on

* Add Microsoft.Maui.Graphics.Skia as PackageReference

* Add Essentials.Samples.Tizen (#24)

* Add Essentials.Samples.Tizen

* Add guard for null exception

* Fix Essentials.Samples for Tizen

* Fix csproj for net6

* Remove Forms.Init

* Fix build error (#60)

* Update referenced Tizen.UIExtensions version (#61)

* Add BlazorWebView skeleton code (#62)

* Bump to latest (#71)

- Window lifecycle (dotnet#1754)
- Move New Navigation Handler to Core and make it internal (dotnet#1800)
- Scrollview handler (dotnet#1669)
- ScrollView Resize + Window Handler Resize (dotnet#1676)
- Font AutoScalingEnabled (dotnet#1774)
- Rename Font Properties (dotnet#1755)
- Update layout system to ensure native measure/arrange are called for all controls, even from Page subclasses (dotnet#1819)
- IContainer as IList<IView> (dotnet#1724)
- Implement Layout padding for new StackLayouts and GridLayout (dotnet#1749)
- Delete all the TabIndex, TabStop, Focusable things! (dotnet#1777)
- Introduce SetSemanticFocus API via SemanticExtensions (dotnet#1829)
- Improve Window and AnimationManager (dotnet#1653)
- And so on

* Remove IPage on Tizen (#72)

- Merge IFrameworkElement and IView and Remove IPage (dotnet#1875)

* Add Blazor webview (#67)

* Add Blazor webview

* Replace space to tab

* remove space

* Fix entry cursor error (#68)

* Fix entry cursor error

* Update code referring to android extension

* Remove duplicate code & Add exception cases

* Code fixes for consistency

* Fix nullable issue (#77)

* Fix Image loading (#78)

* Fix nested layout issue (#79)

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <[email protected]>

* Fix issues caused by bump up (#75)

* Fix issues caused by bump up

* Update Tizen file provider

* Update file provider with proper path

* Fix unmatched partial method (#84)

* Fixes incorrect parameter type for ILayoutManager.ArrangeChildren (Rectangle -> Size). (#91)

* Make the HandlerToRendererShim simple

* Revert "Fixes incorrect parameter type for ILayoutManager.ArrangeChildren (Rectangle -> Size). (#91)" (#97)

This reverts commit c54ac83.

* Refactor the LayoutHandler (#99)

* Fix layout measure issue (#100)

* Fix LayoutHandler Update issue (#103)

* Fix LayoutHandler Update issue

* Implement InvalidateMeasure propagation

* Update MapBackground

* Add InitializationOptions (#107)

* Add InitializationOptions

* Set UseSkiaSharp true as default

* Apply DP as default

* Fix SKClipperView to have proper size (#115)

* Fix Essentials sample (#108)

* Fix Essentials sample for Tizen

* Remove UseSkiaSharp flag

* Remove MaterialComponents

* Fix Tizen flag

* Remove CustomRenderer

* Add ShellHandler (#64)

* Add ShellHandler

* Move ShellView into Platform/Tizen

* Update ShellView

* Move the code for embedded tizen resources to csproj

* Add UIExtenstions for shell

* MAUI workload for Tizen (#66)

* Fix build and runtime error after bumping to latest code

* Fix HandlerToRendererShim dispose (dotnet#127)

* Add ShellSearchView (#121)

* Add ShellSearchView

* Fix the layout issue in ShellSearchResultList

* Enable nullable

* Fix maximum height of ShellSearchResultList

* Fix scaling issue on Clip (dotnet#130)

* Fix DisplayResolutionUnit sync issue (dotnet#134)

* Fix build error (dotnet#137)

* Replace SkiaGraphicsView with local patch (dotnet#135)

This commit will be revert when upstream code is updated

* Support Min/Max Height/Width on IView and applying MauiApp/MauiAppBuilder pattern

- Support Min/Max Height/Width on IView (dotnet#2265)
- Updating .NET MAUI to use MauiApp/MauiAppBuilder pattern and use MS.Extensions.DependencyInjection (dotnet#2137)

* Fix Tizen Templates (dotnet#144)

* Fix webview break caused by updated dependency (dotnet#143)

* Update the Tizen.UIExtension.ElmSharp version (dotnet#145)

* Reomve internal UIExtensions compoments for Shell (dotnet#147)

* Adds missing implementation after bumping to latest main

* [Tizen] Adds BoxView Handler

* [Tizen] Implement ProgressColor property in ProgressBarHandlers

- Implement ProgressColor property in ProgressBarHandlers (dotnet#600)

* [Tizen] Handle ContentViews and templated content in new layout system

* Bump to latest (rc1)

- ImageButtonHandler and Handler Re-usability (dotnet#2352)
- Remove IBoxView (dotnet#2619)
- Add SupportedOSPlatformVersion (dotnet#2565)
- Merge all the .NET 6 projects/solutions (dotnet#2505)
- Shadow Support (dotnet#570)
- Add IndicatorView handler(dotnet#2038)

* [Tizen] Apply graphics related code review feedback

* [Tizen] Port H/V TextAlignment to Editor/Picker Handler

* [Tizen] Add TVShellView (dotnet#183)

* [Tizen] Add TVShellView

* [Tizen] Update TVShellView

* [Tizen] Update NativeView for Shell

* [Tizen] Update ShellView

* [Tizen] Change default FlyoutBackgroundColor for TV

* [Tizen] Enable nullable

* Refactor WrapperView to draw drawable features (dotnet#186)

* Refactor WrapperView to draw drawable features

* Update class names and devide files

* Override NeesContainer to remove duplicated code

* Update class names

* [Tizen] Adds ApplicationHandler

* Fix Background issue of Frame (dotnet#193)

* Fix UpdateBackground (dotnet#194)

* Fix UpdateBackground

* Add ContentView Background mapper

* Fix Editor/Entry/Label/Layout Background

* Add IWrapperViewCanvas.Content

* Add PageHandler Background mapper

* Restore WrapperView

* Remove unnecessary namespace

* [Tizen] Fix build error on PageHandler

* [Tizen] Apply ITextButton related changes

* [Tizen] Add Shadows (dotnet#233)

* [Tizen] Add Shadows

* [Tizen] Apply review comments

* [Tizen] Move updating shape in proper position

* [Tizen] Update BackgroundDrawable

* [Tizen] Apply review comments

* [Tizen] Add BorderDrawable (dotnet#224)

* Move to platform specific

* Fix border handler for Tizen

* Rename ToDrawable method

* Fix border content layout

* Fix BorderView

* Apply rebase

* [Tizen] Fix entry cursor issue (dotnet#222)

* Fix entry cursor issue

* Fix UpdateSelectionLength method

* [Tizen] Remove TVNavigationDrawer TVNavigationView (dotnet#223)

* [Tizen] Remove TVNavigationDrawer TVNavigationView

* [Elmsharp] Update Tizen.UIExtensions version

* [Tizen] Initial Multi Window support

* [Tizen] Fix MauiContext

* [Tizen] Refactor Border by defining MauiDrawable (dotnet#248)

* [Tizen] Refactor Border by defining MauiDrawable

* [Tizen] Apply review comments

* [Tizen] Remove unnecessary type casting

* [Tizen] Move getting path logic to drawable

* [Tizen] Obsolete AndExpand & Remove IsolatedStorage

* Fix tizen solution (.sln) correctly

* [Tizen] Add VerticalTextAlignment

* [Tizen] Fix Scoping of MauiContext

* [Tizen] Use CoreApplication as native app type

* [Tizen] Applying upstream changes

* [Tizen] Add ContainerView to Layout if it's present

* [Tizen] Initial Reloadyfy support

* [Tizen] Initial IVisualDiagnosticOveraly support

* [Tizen] Move types in the Platform folder into the Platform namespaces

* Fix CollectionView layout issue (dotnet#288)

* Fix CollectionView layout issue

* Remove unnecessary code

* [Tizen] ZIndex proof-of-concept

* Fix ScrollView ContentSize and Padding margin (dotnet#291)

* Fix ScrollView ContentSize and Padding margin

* Fix MapRequestScrollTo

* Update src/Core/src/Handlers/ScrollView/ScrollViewHandler.Tizen.cs

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <[email protected]>

* Update src/Core/src/Handlers/ScrollView/ScrollViewHandler.Tizen.cs

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <[email protected]>

* Remove MapContentSize

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <[email protected]>

* Implements WindowOverlay and VisualDiagnosticsOverlay (dotnet#294)

* Implements WindowOverlay and VisualDiagnosticsOverlay

* Apply code review

* [Tizen] Fix Image Handler

* Remove GetDesiredSize (dotnet#295)

* [Tizen] Fix ButtonHandler

* [Tizen] Organize and centralize HandlerExtensions

* Refactor WrapperView and Fix Issue (dotnet#302)

* Refactor WrapperView

* Use Thickness type for Shadow margin

* Update variable name

* Update class name to GraphicsExtensions

* Fix essentials sample for Tizen (dotnet#305)

* [Tizen] Fix NativeView casting issue

* Fix BlazorWebview binary resource issue (dotnet#317)

* [Tizen] Handle query strings in Blazor static assets by trimming them out

* Refactor MauiContext (dotnet#330)

* [Tizen] Adds PaintExtensions

* [Tizen] Implement CursorPosition in IEditor/ITextInput Handlers

* [Tizen] Remove GetNative

* [Tizen] Update Microsoft.NET.Sdk.Maui/WorkloadManifest

* [Tizen] Bump to latest

* [Tizen] Use legacy compat renderers temporarily

* [Tizen] Implement IPlatformApplication.Current

* [Tizen] Fix INativeViewHandler to return more expected NativeView

* [Tizen] Remove legacy TFMs

* [Tizen] Remove `IPlatformInvalidate` and `Device.Invalidate()

* [Tizen] Fix Essential sample build error

* [Tizen] Refactor Essential's implementations

* [Tizen] Renaming public APIs Native -> Platform

* [Tizen] Interfaced Handler for Label, Page, NavigationView, Picker,
ProgressBar, SwipeView

* [Tizen] Moved GetPlatformSize logic into a new service

* [Tizen] Interfaced handler for Switch, TimePicker, WebView, Slider,
SearchBar, RefreshView, RadioButton

* [Tizen] Fix build error after rebasing

* [Tizen] Move TabbedPageHandler to TabbedViewHandler

* [Tizen] Backport p14 changes

* [Tizen] Loaded/Unloaded events and propagate Window

* [Tizen] Implement FillRule property in Polygon/PolylineHandler

* [Tizen] Add install tizen to provision.yml

* [Tizen] Move package version into Versions.props

* Adds the Tizen backend

* [Tizen] Add Resizetizer Tizen Implementation

* Bump to latest and fix build error

* Bump to latest

- Apply to start adding in APIs for adding legacy renderers via assembly scanning (dotnet#1333)
- Update to IMauiContext (dotnet#1357)
- and so on

* Bump to latest

- Apply to patch related to Animation (dotnet#1436)
- Apply to register Microsoft.Maui.Graphics Platforms (dotnet#1441)
- and so on.

* Bump to latest

- Modal Navigation Manager (dotnet#1563)
- Implement the basic WindowHandler (dotnet#1468)
- Don't extract native defaults, meaning users can no longer reset a color back to a platform theme (dotnet#1485)
- Implement Alerts (Alert, Prompt and ActionSheet) (dotnet#1328)
- And so on.

* Bumt to latest

- Effects (dotnet#1574)
- Improve Window and AnimationManager (dotnet#1653)
- and so on

* Fix build error (#60)

* Bump to latest (#71)

- Window lifecycle (dotnet#1754)
- Move New Navigation Handler to Core and make it internal (dotnet#1800)
- Scrollview handler (dotnet#1669)
- ScrollView Resize + Window Handler Resize (dotnet#1676)
- Font AutoScalingEnabled (dotnet#1774)
- Rename Font Properties (dotnet#1755)
- Update layout system to ensure native measure/arrange are called for all controls, even from Page subclasses (dotnet#1819)
- IContainer as IList<IView> (dotnet#1724)
- Implement Layout padding for new StackLayouts and GridLayout (dotnet#1749)
- Delete all the TabIndex, TabStop, Focusable things! (dotnet#1777)
- Introduce SetSemanticFocus API via SemanticExtensions (dotnet#1829)
- Improve Window and AnimationManager (dotnet#1653)
- And so on

* Bump to latest

* Fix Essentials sample (#108)

* Fix Essentials sample for Tizen

* Remove UseSkiaSharp flag

* Remove MaterialComponents

* Fix Tizen flag

* Remove CustomRenderer

* Add ShellHandler (#64)

* Add ShellHandler

* Move ShellView into Platform/Tizen

* Update ShellView

* Move the code for embedded tizen resources to csproj

* Add UIExtenstions for shell

* MAUI workload for Tizen (#66)

* Fix build and runtime error after bumping to latest code

* Fix Essentials (dotnet#146)

* Fix Essentials sample for tizen

* Add SemanticScreenReader for Tizen

* Fix Startup

* Adds missing implementation after bumping to latest main

* Bump to latest (rc1)

- ImageButtonHandler and Handler Re-usability (dotnet#2352)
- Remove IBoxView (dotnet#2619)
- Add SupportedOSPlatformVersion (dotnet#2565)
- Merge all the .NET 6 projects/solutions (dotnet#2505)
- Shadow Support (dotnet#570)
- Add IndicatorView handler(dotnet#2038)

* Refactor WrapperView to draw drawable features (dotnet#186)

* Refactor WrapperView to draw drawable features

* Update class names and devide files

* Override NeesContainer to remove duplicated code

* Update class names

* [Tizen] Adds ApplicationHandler

* Fix UpdateBackground (dotnet#194)

* Fix UpdateBackground

* Add ContentView Background mapper

* Fix Editor/Entry/Label/Layout Background

* Add IWrapperViewCanvas.Content

* Add PageHandler Background mapper

* Restore WrapperView

* Remove unnecessary namespace

* [Tizen] Add BorderDrawable (dotnet#224)

* Move to platform specific

* Fix border handler for Tizen

* Rename ToDrawable method

* Fix border content layout

* Fix BorderView

* Apply rebase

* [Tizen] Refactor Border by defining MauiDrawable (dotnet#248)

* [Tizen] Refactor Border by defining MauiDrawable

* [Tizen] Apply review comments

* [Tizen] Remove unnecessary type casting

* [Tizen] Move getting path logic to drawable

* [Tizen] Fix Scoping of MauiContext

* [Tizen] Applying upstream changes

* [Tizen] Move types in the Platform folder into the Platform namespaces

* [Tizen] Fix ButtonHandler

* [Tizen] Organize and centralize HandlerExtensions

* Refactor MauiContext (dotnet#330)

* Add NUI handler

* [Tizen] Refactor MauiApplication and MauiContext (dotnet#216)

* Add AlertManager (dotnet#214)

* Code clean up (dotnet#218)

* Fix build error on Controls.Sample (dotnet#225)

* [Tizen] Initail CollectionViewHandler for NUI

* Fix PlatformEffect NativeView type (dotnet#231)

* Fix Control.Sample correctly (dotnet#234)

* Fix NamedSize (dotnet#242)

* Update NavigationPageRenderer (dotnet#238)

- Implement title view

* Fix build errors and apply upstream changes

* Refactoring Window and modal (dotnet#246)

* Obsolete AndExpand & fix build eror

* [NUI] Implement BlazorWebView (dotnet#259)

* Implement BlazorWebView

* Update NUI WebView alias name

* Bump to latest

* Fix MinimumWidth/Height MaximumWidth/Height (dotnet#270)

* [NUI] Add GestureManager (dotnet#272)

* Add gesture handler

* enable nullable

* use lazy

* Remove unnessary EFL code in ScrollViewHandler (dotnet#274)

* Add TabbedPage Renderer (dotnet#275)

* [NUI] Implement WrapperView enabling Border and Shadow (dotnet#273)

* [NUI] Add MauiDrawable enabling Border and Shadow

* [NUI] Remove BorderView type and refactor

* Refactor StrokeExtensions

* Remove unnecessary code

* Update a way clearing content

* [NUI] Add Picker handler (dotnet#276)

* Add Picker handler

* Apply code review

* Change timing adding event handler

* Update Picker on touch (dotnet#293)

* Fix NeedsContainer (dotnet#306)

* Update FrameRenderer to support Brush (dotnet#309)

* Fix minor layout issue (dotnet#314)

* Fix build error

* Fix ScrollView ContentSize (dotnet#324)

* Refactor Maui context (dotnet#328)

* Fix build error after bumping to latest

* [Tizen] Add ImageButtonHandler (dotnet#334)

* [NUI] Implement Editor/Entry handler (dotnet#335)

* Implement Editor/Entry handler

* Fix measure issue

* Update paramer name

* Fix if statement

* Fix Editor/Entry CursorPosition issue (dotnet#336)

* [NUI] Add CollectionViewHandler (dotnet#352)

* Fix EmptyView on CollectionView

* Add CollectionViewHandler

* Add SearchBar handler (dotnet#354)

* Implement Clip (dotnet#384)

* Bump to latest

* [NUI] Add TimePickerHandler (dotnet#390)

* [NUI] Add TimePickerHandler

* Update button placement

* Clean up code after rebase (dotnet#399)

* Fix TabbedPage to use Controls.Grid instead Compatibility.Grid (dotnet#400)

* Fix Controls MapText (dotnet#406)

* Fix focus management (dotnet#407)

* Update WrapperView (dotnet#409)

* Update Tizen platform to tizen10.0 (dotnet#416)

* Update WebView handler and MauiWebView handler (dotnet#417)

* Update Label shadow (dotnet#420)

* Fix build error after rebase

* Fix InputTransparent (dotnet#424)

* Implement CarouselView handler (dotnet#428)

* Fix GestureManager crash issue (dotnet#432)

* Update WebView EvaluateJavaScript async (dotnet#435)

* Fix CascadeInputTransparent (dotnet#442)

* Add NavigationView handler (dotnet#449)

* Update WindowOverlay handler (dotnet#452)

* Update ViewExtensions (dotnet#455)

* Update ImageSourceService (dotnet#454)

* Fix MauiSearchBar IsEnabled property (dotnet#458)

* Add SwipeView handler (dotnet#460)

* Clean code after rebase

* Fix GetPath to return a correct path (dotnet#465)

* Update for focus navigation (dotnet#459)

* Cleanup code after rebase

* Fix build error after rebase

* Implement UpdateBackgroundImageSourceAsync extensions method (dotnet#479)

* [NUI] Update SliderHandler with NUI slider component (dotnet#487)

* Update SliderHandler with NUI compnent

* Update SliderHandler with review feedback

* Update with review feedback

* Fix GetPlatformViewBounds as Pixel coordinate (dotnet#488)

* Fix ScrollView content size update issue (dotnet#492)

* Implement Controls.Compatibility for tizen (dotnet#493)

* Optimize Layout Measure (dotnet#495)

* Code cleanup after code rebase

* Fix z-order on Layout (dotnet#497)

* [NUI] Update StepperHandler (dotnet#498)

* Update StepperHandler

* Apply Review comment

* Fix Frame measure (dotnet#501)

* Fix BorderView (dotnet#500)

* Add RadioButton handler (dotnet#499)

* Fix CollectionView Item measure (dotnet#502)

* Fix Measure contraint convert (dotnet#504)

* Fix WrapperView measure (dotnet#507)

* Implement Missing mapper (dotnet#509)

* Fix WrapperView Width/HeightSpecification (dotnet#510)

* Fix ShapeView (dotnet#511)

* Optimize View measure (dotnet#513)

* Fix NavigationPage disposing pages (dotnet#514)

* Fix build error after rebase

* Fix WebView (dotnet#515)

* Fix TableView (dotnet#516)

* Fix Compatibility Cell templates (dotnet#517)

* [NUI] Add IndicatorViewHandler (dotnet#518)

* Add IndicatorViewHandler

* Update review comment

* Add space

* Fix ListViewRenderer (dotnet#519)

* Fix Binding error on CollectionView (dotnet#520)

* Fix layout issue when view was shown from hide (dotnet#522)

* [NUI] Fix ImageButton Clicked (dotnet#523)

* Fix ImageButton Clicked

* Apply review comment

* Fix BlazorWebView RequestIntercept issue (dotnet#524)

* Fix Layout size issue (dotnet#525)

* Fix build error after rebase

* [NUI] Add DatePicker Handler (dotnet#528)

* Add DatePicker

* Add missing class

* Update Style and Use DummyPopupPage

* Refactoring with MauiTimePicker

* add new file

Co-authored-by: Jay Cho <[email protected]>

* Fix GetBoundingBox/OverlayWindow touch point coordinate to DP (dotnet#529)

* Fix CollectionView EmptyView HeaderFooter (dotnet#530)

* Update DateTimePicker width on horizontal (dotnet#531)

* Fix DisconnectHandler (dotnet#532)

* Update Page default background color (dotnet#533)

* Clean up NuGet.config (dotnet#535)

* [NUI] Update font size (dotnet#536)

* Update FontNamedSize

* adjust font size on tv profile

* Add RefreshViewHandler (dotnet#490)

* [Tizen] Refactor compat renderers (dotnet#538)

* [Tizen] Refactor the TabbedPageRenderer (dotnet#541)

* [Tizen] Add FlyoutViewHandler (dotnet#540)

* Add FlyoutView

* Update FlyoutView to cover TV drawer

* Add missing connecting handler

* Update handler implementation using extensions

* Simplify code

Co-authored-by: Jay Cho <[email protected]>

* [Tizen] Add MauiPicker (dotnet#543)

* Add MenuIcon to Toolbar (dotnet#542)

* Add MenuIcon to Toolbar

* Apply Reviews

Co-authored-by: Jay Cho <[email protected]>

* [Tizen] Add ShellHandler (dotnet#539)

* [NUI] Add ShellHandler

* Update PublicAPI.Shipped.txt file

* Fix build error

* Update AppHostingBuilder

* Update ShellView with review feedback

* Remove unnecessary code

* Update Shell navigation stack

* Add IDisposable interface

* Update ShellSectionView

* Update AdppHostBuilderExtensions

* Rebase and update toolbar to resolve conflict

* Remove ShellContentHandler and update ToolbarHandler

* Update ShellView to handle DrawerToggleVisible

* Remove unnecessary code

* Fix build error after rebase

Co-authored-by: Kangho Hur <[email protected]>
Co-authored-by: 조중현/Common Platform Lab(SR)/Engineer/삼성전자 <[email protected]>
Co-authored-by: 김성수/Common Platform Lab(SR)/Staff Engineer/삼성전자 <[email protected]>
Co-authored-by: 박인서/Common Platform Lab(SR)/Associate/삼성전자 <[email protected]>
Co-authored-by: 민성현/Common Platform Lab(SR)/Staff Engineer/삼성전자 <[email protected]>
Co-authored-by: Jay Cho <[email protected]>
myroot added a commit to myroot/maui that referenced this pull request Aug 24, 2022
@myroot
Fix GetBoundingBox/OverlayWindow touch point coordinate to DP (dotnet…
3f20f9e 
…#529)
myroot added a commit to myroot/maui that referenced this pull request Aug 25, 2022
@myroot
Fix GetBoundingBox/OverlayWindow touch point coordinate to DP (dotnet…
48f7b18 
…#529)
rmarinho pushed a commit that referenced this pull request Aug 26, 2022
@myroot @rookiejava
@JoonghyunCho @sung-su @shyunMin
Replace Tizen Backend engine (#9620)
a27241f 
* Remove comment

* Remove image resource on Tizen project

* Remove space

* Fix compatibility issue (#41)

* Fix compatibility issue

* Fix Compatibility Resource path

* Bump to latest

- Modal Navigation Manager (#1563)
- Implement the basic WindowHandler (#1468)
- Don't extract native defaults, meaning users can no longer reset a color back to a platform theme (#1485)
- Implement Alerts (Alert, Prompt and ActionSheet) (#1328)
- And so on.

* [SingleProject] Fix Issues (#50)

* Bumt to latest

- Effects (#1574)
- Improve Window and AnimationManager (#1653)
- and so on

* Add Microsoft.Maui.Graphics.Skia as PackageReference

* Add Essentials.Samples.Tizen (#24)

* Add Essentials.Samples.Tizen

* Add guard for null exception

* Fix Essentials.Samples for Tizen

* Fix csproj for net6

* Remove Forms.Init

* Fix build error (#60)

* Update referenced Tizen.UIExtensions version (#61)

* Add BlazorWebView skeleton code (#62)

* Bump to latest (#71)

- Window lifecycle (#1754)
- Move New Navigation Handler to Core and make it internal (#1800)
- Scrollview handler (#1669)
- ScrollView Resize + Window Handler Resize (#1676)
- Font AutoScalingEnabled (#1774)
- Rename Font Properties (#1755)
- Update layout system to ensure native measure/arrange are called for all controls, even from Page subclasses (#1819)
- IContainer as IList<IView> (#1724)
- Implement Layout padding for new StackLayouts and GridLayout (#1749)
- Delete all the TabIndex, TabStop, Focusable things! (#1777)
- Introduce SetSemanticFocus API via SemanticExtensions (#1829)
- Improve Window and AnimationManager (#1653)
- And so on

* Remove IPage on Tizen (#72)

- Merge IFrameworkElement and IView and Remove IPage (#1875)

* Add Blazor webview (#67)

* Add Blazor webview

* Replace space to tab

* remove space

* Fix entry cursor error (#68)

* Fix entry cursor error

* Update code referring to android extension

* Remove duplicate code & Add exception cases

* Code fixes for consistency

* Fix nullable issue (#77)

* Fix Image loading (#78)

* Fix nested layout issue (#79)

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <[email protected]>

* Fix issues caused by bump up (#75)

* Fix issues caused by bump up

* Update Tizen file provider

* Update file provider with proper path

* Fix unmatched partial method (#84)

* Fixes incorrect parameter type for ILayoutManager.ArrangeChildren (Rectangle -> Size). (#91)

* Make the HandlerToRendererShim simple

* Revert "Fixes incorrect parameter type for ILayoutManager.ArrangeChildren (Rectangle -> Size). (#91)" (#97)

This reverts commit c54ac83.

* Refactor the LayoutHandler (#99)

* Fix layout measure issue (#100)

* Fix LayoutHandler Update issue (#103)

* Fix LayoutHandler Update issue

* Implement InvalidateMeasure propagation

* Update MapBackground

* Add InitializationOptions (#107)

* Add InitializationOptions

* Set UseSkiaSharp true as default

* Apply DP as default

* Fix SKClipperView to have proper size (#115)

* Fix Essentials sample (#108)

* Fix Essentials sample for Tizen

* Remove UseSkiaSharp flag

* Remove MaterialComponents

* Fix Tizen flag

* Remove CustomRenderer

* Add ShellHandler (#64)

* Add ShellHandler

* Move ShellView into Platform/Tizen

* Update ShellView

* Move the code for embedded tizen resources to csproj

* Add UIExtenstions for shell

* MAUI workload for Tizen (#66)

* Fix build and runtime error after bumping to latest code

* Fix HandlerToRendererShim dispose (#127)

* Add ShellSearchView (#121)

* Add ShellSearchView

* Fix the layout issue in ShellSearchResultList

* Enable nullable

* Fix maximum height of ShellSearchResultList

* Fix scaling issue on Clip (#130)

* Fix DisplayResolutionUnit sync issue (#134)

* Fix build error (#137)

* Replace SkiaGraphicsView with local patch (#135)

This commit will be revert when upstream code is updated

* Support Min/Max Height/Width on IView and applying MauiApp/MauiAppBuilder pattern

- Support Min/Max Height/Width on IView (#2265)
- Updating .NET MAUI to use MauiApp/MauiAppBuilder pattern and use MS.Extensions.DependencyInjection (#2137)

* Fix Tizen Templates (#144)

* Fix webview break caused by updated dependency (#143)

* Update the Tizen.UIExtension.ElmSharp version (#145)

* Reomve internal UIExtensions compoments for Shell (#147)

* Adds missing implementation after bumping to latest main

* [Tizen] Adds BoxView Handler

* [Tizen] Implement ProgressColor property in ProgressBarHandlers

- Implement ProgressColor property in ProgressBarHandlers (#600)

* [Tizen] Handle ContentViews and templated content in new layout system

* Bump to latest (rc1)

- ImageButtonHandler and Handler Re-usability (#2352)
- Remove IBoxView (#2619)
- Add SupportedOSPlatformVersion (#2565)
- Merge all the .NET 6 projects/solutions (#2505)
- Shadow Support (#570)
- Add IndicatorView handler(#2038)

* [Tizen] Apply graphics related code review feedback

* [Tizen] Port H/V TextAlignment to Editor/Picker Handler

* [Tizen] Add TVShellView (#183)

* [Tizen] Add TVShellView

* [Tizen] Update TVShellView

* [Tizen] Update NativeView for Shell

* [Tizen] Update ShellView

* [Tizen] Change default FlyoutBackgroundColor for TV

* [Tizen] Enable nullable

* Refactor WrapperView to draw drawable features (#186)

* Refactor WrapperView to draw drawable features

* Update class names and devide files

* Override NeesContainer to remove duplicated code

* Update class names

* [Tizen] Adds ApplicationHandler

* Fix Background issue of Frame (#193)

* Fix UpdateBackground (#194)

* Fix UpdateBackground

* Add ContentView Background mapper

* Fix Editor/Entry/Label/Layout Background

* Add IWrapperViewCanvas.Content

* Add PageHandler Background mapper

* Restore WrapperView

* Remove unnecessary namespace

* [Tizen] Fix build error on PageHandler

* [Tizen] Apply ITextButton related changes

* [Tizen] Add Shadows (#233)

* [Tizen] Add Shadows

* [Tizen] Apply review comments

* [Tizen] Move updating shape in proper position

* [Tizen] Update BackgroundDrawable

* [Tizen] Apply review comments

* [Tizen] Add BorderDrawable (#224)

* Move to platform specific

* Fix border handler for Tizen

* Rename ToDrawable method

* Fix border content layout

* Fix BorderView

* Apply rebase

* [Tizen] Fix entry cursor issue (#222)

* Fix entry cursor issue

* Fix UpdateSelectionLength method

* [Tizen] Remove TVNavigationDrawer TVNavigationView (#223)

* [Tizen] Remove TVNavigationDrawer TVNavigationView

* [Elmsharp] Update Tizen.UIExtensions version

* [Tizen] Initial Multi Window support

* [Tizen] Fix MauiContext

* [Tizen] Refactor Border by defining MauiDrawable (#248)

* [Tizen] Refactor Border by defining MauiDrawable

* [Tizen] Apply review comments

* [Tizen] Remove unnecessary type casting

* [Tizen] Move getting path logic to drawable

* [Tizen] Obsolete AndExpand & Remove IsolatedStorage

* Fix tizen solution (.sln) correctly

* [Tizen] Add VerticalTextAlignment

* [Tizen] Fix Scoping of MauiContext

* [Tizen] Use CoreApplication as native app type

* [Tizen] Applying upstream changes

* [Tizen] Add ContainerView to Layout if it's present

* [Tizen] Initial Reloadyfy support

* [Tizen] Initial IVisualDiagnosticOveraly support

* [Tizen] Move types in the Platform folder into the Platform namespaces

* Fix CollectionView layout issue (#288)

* Fix CollectionView layout issue

* Remove unnecessary code

* [Tizen] ZIndex proof-of-concept

* Fix ScrollView ContentSize and Padding margin (#291)

* Fix ScrollView ContentSize and Padding margin

* Fix MapRequestScrollTo

* Update src/Core/src/Handlers/ScrollView/ScrollViewHandler.Tizen.cs

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <[email protected]>

* Update src/Core/src/Handlers/ScrollView/ScrollViewHandler.Tizen.cs

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <[email protected]>

* Remove MapContentSize

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <[email protected]>

* Implements WindowOverlay and VisualDiagnosticsOverlay (#294)

* Implements WindowOverlay and VisualDiagnosticsOverlay

* Apply code review

* [Tizen] Fix Image Handler

* Remove GetDesiredSize (#295)

* [Tizen] Fix ButtonHandler

* [Tizen] Organize and centralize HandlerExtensions

* Refactor WrapperView and Fix Issue (#302)

* Refactor WrapperView

* Use Thickness type for Shadow margin

* Update variable name

* Update class name to GraphicsExtensions

* Fix essentials sample for Tizen (#305)

* [Tizen] Fix NativeView casting issue

* Fix BlazorWebview binary resource issue (#317)

* [Tizen] Handle query strings in Blazor static assets by trimming them out

* Refactor MauiContext (#330)

* [Tizen] Adds PaintExtensions

* [Tizen] Implement CursorPosition in IEditor/ITextInput Handlers

* [Tizen] Remove GetNative

* [Tizen] Update Microsoft.NET.Sdk.Maui/WorkloadManifest

* [Tizen] Bump to latest

* [Tizen] Use legacy compat renderers temporarily

* [Tizen] Implement IPlatformApplication.Current

* [Tizen] Fix INativeViewHandler to return more expected NativeView

* [Tizen] Remove legacy TFMs

* [Tizen] Remove `IPlatformInvalidate` and `Device.Invalidate()

* [Tizen] Fix Essential sample build error

* [Tizen] Refactor Essential's implementations

* [Tizen] Renaming public APIs Native -> Platform

* [Tizen] Interfaced Handler for Label, Page, NavigationView, Picker,
ProgressBar, SwipeView

* [Tizen] Moved GetPlatformSize logic into a new service

* [Tizen] Interfaced handler for Switch, TimePicker, WebView, Slider,
SearchBar, RefreshView, RadioButton

* [Tizen] Fix build error after rebasing

* [Tizen] Move TabbedPageHandler to TabbedViewHandler

* [Tizen] Backport p14 changes

* [Tizen] Loaded/Unloaded events and propagate Window

* [Tizen] Implement FillRule property in Polygon/PolylineHandler

* [Tizen] Add install tizen to provision.yml

* [Tizen] Move package version into Versions.props

* Adds the Tizen backend

* [Tizen] Add Resizetizer Tizen Implementation

* Bump to latest and fix build error

* Bump to latest

- Apply to start adding in APIs for adding legacy renderers via assembly scanning (#1333)
- Update to IMauiContext (#1357)
- and so on

* Bump to latest

- Apply to patch related to Animation (#1436)
- Apply to register Microsoft.Maui.Graphics Platforms (#1441)
- and so on.

* Bump to latest

- Modal Navigation Manager (#1563)
- Implement the basic WindowHandler (#1468)
- Don't extract native defaults, meaning users can no longer reset a color back to a platform theme (#1485)
- Implement Alerts (Alert, Prompt and ActionSheet) (#1328)
- And so on.

* Bumt to latest

- Effects (#1574)
- Improve Window and AnimationManager (#1653)
- and so on

* Fix build error (#60)

* Bump to latest (#71)

- Window lifecycle (#1754)
- Move New Navigation Handler to Core and make it internal (#1800)
- Scrollview handler (#1669)
- ScrollView Resize + Window Handler Resize (#1676)
- Font AutoScalingEnabled (#1774)
- Rename Font Properties (#1755)
- Update layout system to ensure native measure/arrange are called for all controls, even from Page subclasses (#1819)
- IContainer as IList<IView> (#1724)
- Implement Layout padding for new StackLayouts and GridLayout (#1749)
- Delete all the TabIndex, TabStop, Focusable things! (#1777)
- Introduce SetSemanticFocus API via SemanticExtensions (#1829)
- Improve Window and AnimationManager (#1653)
- And so on

* Bump to latest

* Fix Essentials sample (#108)

* Fix Essentials sample for Tizen

* Remove UseSkiaSharp flag

* Remove MaterialComponents

* Fix Tizen flag

* Remove CustomRenderer

* Add ShellHandler (#64)

* Add ShellHandler

* Move ShellView into Platform/Tizen

* Update ShellView

* Move the code for embedded tizen resources to csproj

* Add UIExtenstions for shell

* MAUI workload for Tizen (#66)

* Fix build and runtime error after bumping to latest code

* Fix Essentials (#146)

* Fix Essentials sample for tizen

* Add SemanticScreenReader for Tizen

* Fix Startup

* Adds missing implementation after bumping to latest main

* Bump to latest (rc1)

- ImageButtonHandler and Handler Re-usability (#2352)
- Remove IBoxView (#2619)
- Add SupportedOSPlatformVersion (#2565)
- Merge all the .NET 6 projects/solutions (#2505)
- Shadow Support (#570)
- Add IndicatorView handler(#2038)

* Refactor WrapperView to draw drawable features (#186)

* Refactor WrapperView to draw drawable features

* Update class names and devide files

* Override NeesContainer to remove duplicated code

* Update class names

* [Tizen] Adds ApplicationHandler

* Fix UpdateBackground (#194)

* Fix UpdateBackground

* Add ContentView Background mapper

* Fix Editor/Entry/Label/Layout Background

* Add IWrapperViewCanvas.Content

* Add PageHandler Background mapper

* Restore WrapperView

* Remove unnecessary namespace

* [Tizen] Add BorderDrawable (#224)

* Move to platform specific

* Fix border handler for Tizen

* Rename ToDrawable method

* Fix border content layout

* Fix BorderView

* Apply rebase

* [Tizen] Refactor Border by defining MauiDrawable (#248)

* [Tizen] Refactor Border by defining MauiDrawable

* [Tizen] Apply review comments

* [Tizen] Remove unnecessary type casting

* [Tizen] Move getting path logic to drawable

* [Tizen] Fix Scoping of MauiContext

* [Tizen] Applying upstream changes

* [Tizen] Move types in the Platform folder into the Platform namespaces

* [Tizen] Fix ButtonHandler

* [Tizen] Organize and centralize HandlerExtensions

* Refactor MauiContext (#330)

* Add NUI handler

* [Tizen] Refactor MauiApplication and MauiContext (#216)

* Add AlertManager (#214)

* Code clean up (#218)

* Fix build error on Controls.Sample (#225)

* [Tizen] Initail CollectionViewHandler for NUI

* Fix PlatformEffect NativeView type (#231)

* Fix Control.Sample correctly (#234)

* Fix NamedSize (#242)

* Update NavigationPageRenderer (#238)

- Implement title view

* Fix build errors and apply upstream changes

* Refactoring Window and modal (#246)

* Obsolete AndExpand & fix build eror

* [NUI] Implement BlazorWebView (#259)

* Implement BlazorWebView

* Update NUI WebView alias name

* Bump to latest

* Fix MinimumWidth/Height MaximumWidth/Height (#270)

* [NUI] Add GestureManager (#272)

* Add gesture handler

* enable nullable

* use lazy

* Remove unnessary EFL code in ScrollViewHandler (#274)

* Add TabbedPage Renderer (#275)

* [NUI] Implement WrapperView enabling Border and Shadow (#273)

* [NUI] Add MauiDrawable enabling Border and Shadow

* [NUI] Remove BorderView type and refactor

* Refactor StrokeExtensions

* Remove unnecessary code

* Update a way clearing content

* [NUI] Add Picker handler (#276)

* Add Picker handler

* Apply code review

* Change timing adding event handler

* Update Picker on touch (#293)

* Fix NeedsContainer (#306)

* Update FrameRenderer to support Brush (#309)

* Fix minor layout issue (#314)

* Fix build error

* Fix ScrollView ContentSize (#324)

* Refactor Maui context (#328)

* Fix build error after bumping to latest

* [Tizen] Add ImageButtonHandler (#334)

* [NUI] Implement Editor/Entry handler (#335)

* Implement Editor/Entry handler

* Fix measure issue

* Update paramer name

* Fix if statement

* Fix Editor/Entry CursorPosition issue (#336)

* [NUI] Add CollectionViewHandler (#352)

* Fix EmptyView on CollectionView

* Add CollectionViewHandler

* Add SearchBar handler (#354)

* Implement Clip (#384)

* Bump to latest

* [NUI] Add TimePickerHandler (#390)

* [NUI] Add TimePickerHandler

* Update button placement

* Clean up code after rebase (#399)

* Fix TabbedPage to use Controls.Grid instead Compatibility.Grid (#400)

* Fix Controls MapText (#406)

* Fix focus management (#407)

* Update WrapperView (#409)

* Update Tizen platform to tizen10.0 (#416)

* Update WebView handler and MauiWebView handler (#417)

* Update Label shadow (#420)

* Fix build error after rebase

* Fix InputTransparent (#424)

* Implement CarouselView handler (#428)

* Fix GestureManager crash issue (#432)

* Update WebView EvaluateJavaScript async (#435)

* Fix CascadeInputTransparent (#442)

* Add NavigationView handler (#449)

* Update WindowOverlay handler (#452)

* Update ViewExtensions (#455)

* Update ImageSourceService (#454)

* Fix MauiSearchBar IsEnabled property (#458)

* Add SwipeView handler (#460)

* Clean code after rebase

* Fix GetPath to return a correct path (#465)

* Update for focus navigation (#459)

* Cleanup code after rebase

* Fix build error after rebase

* Implement UpdateBackgroundImageSourceAsync extensions method (#479)

* [NUI] Update SliderHandler with NUI slider component (#487)

* Update SliderHandler with NUI compnent

* Update SliderHandler with review feedback

* Update with review feedback

* Fix GetPlatformViewBounds as Pixel coordinate (#488)

* Fix ScrollView content size update issue (#492)

* Implement Controls.Compatibility for tizen (#493)

* Optimize Layout Measure (#495)

* Code cleanup after code rebase

* Fix z-order on Layout (#497)

* [NUI] Update StepperHandler (#498)

* Update StepperHandler

* Apply Review comment

* Fix Frame measure (#501)

* Fix BorderView (#500)

* Add RadioButton handler (#499)

* Fix CollectionView Item measure (#502)

* Fix Measure contraint convert (#504)

* Fix WrapperView measure (#507)

* Implement Missing mapper (#509)

* Fix WrapperView Width/HeightSpecification (#510)

* Fix ShapeView (#511)

* Optimize View measure (#513)

* Fix NavigationPage disposing pages (#514)

* Fix build error after rebase

* Fix WebView (#515)

* Fix TableView (#516)

* Fix Compatibility Cell templates (#517)

* [NUI] Add IndicatorViewHandler (#518)

* Add IndicatorViewHandler

* Update review comment

* Add space

* Fix ListViewRenderer (#519)

* Fix Binding error on CollectionView (#520)

* Fix layout issue when view was shown from hide (#522)

* [NUI] Fix ImageButton Clicked (#523)

* Fix ImageButton Clicked

* Apply review comment

* Fix BlazorWebView RequestIntercept issue (#524)

* Fix Layout size issue (#525)

* Fix build error after rebase

* [NUI] Add DatePicker Handler (#528)

* Add DatePicker

* Add missing class

* Update Style and Use DummyPopupPage

* Refactoring with MauiTimePicker

* add new file

Co-authored-by: Jay Cho <[email protected]>

* Fix GetBoundingBox/OverlayWindow touch point coordinate to DP (#529)

* Fix CollectionView EmptyView HeaderFooter (#530)

* Update DateTimePicker width on horizontal (#531)

* Fix DisconnectHandler (#532)

* Update Page default background color (#533)

* Clean up NuGet.config (#535)

* [NUI] Update font size (#536)

* Update FontNamedSize

* adjust font size on tv profile

* Add RefreshViewHandler (#490)

* [Tizen] Refactor compat renderers (#538)

* [Tizen] Refactor the TabbedPageRenderer (#541)

* [Tizen] Add FlyoutViewHandler (#540)

* Add FlyoutView

* Update FlyoutView to cover TV drawer

* Add missing connecting handler

* Update handler implementation using extensions

* Simplify code

Co-authored-by: Jay Cho <[email protected]>

* [Tizen] Add MauiPicker (#543)

* Add MenuIcon to Toolbar (#542)

* Add MenuIcon to Toolbar

* Apply Reviews

Co-authored-by: Jay Cho <[email protected]>

* [Tizen] Add ShellHandler (#539)

* [NUI] Add ShellHandler

* Update PublicAPI.Shipped.txt file

* Fix build error

* Update AppHostingBuilder

* Update ShellView with review feedback

* Remove unnecessary code

* Update Shell navigation stack

* Add IDisposable interface

* Update ShellSectionView

* Update AdppHostBuilderExtensions

* Rebase and update toolbar to resolve conflict

* Remove ShellContentHandler and update ToolbarHandler

* Update ShellView to handle DrawerToggleVisible

* Remove unnecessary code

* Fix build error after rebase

Co-authored-by: Kangho Hur <[email protected]>
Co-authored-by: 조중현/Common Platform Lab(SR)/Engineer/삼성전자 <[email protected]>
Co-authored-by: 김성수/Common Platform Lab(SR)/Staff Engineer/삼성전자 <[email protected]>
Co-authored-by: 박인서/Common Platform Lab(SR)/Associate/삼성전자 <[email protected]>
Co-authored-by: 민성현/Common Platform Lab(SR)/Staff Engineer/삼성전자 <[email protected]>
Co-authored-by: Jay Cho <[email protected]>

Co-authored-by: Kangho Hur <[email protected]>
Co-authored-by: 조중현/Common Platform Lab(SR)/Engineer/삼성전자 <[email protected]>
Co-authored-by: 김성수/Common Platform Lab(SR)/Staff Engineer/삼성전자 <[email protected]>
Co-authored-by: 박인서/Common Platform Lab(SR)/Associate/삼성전자 <[email protected]>
Co-authored-by: 민성현/Common Platform Lab(SR)/Staff Engineer/삼성전자 <[email protected]>
Co-authored-by: Jay Cho <[email protected]>
rmarinho pushed a commit that referenced this pull request Aug 26, 2022
@myroot @rookiejava
@JoonghyunCho @sung-su @shyunMin
[main][Tizen] Replace Tizen Backend engine (#9619)
9ee62c1 
* Remove comment

* Remove image resource on Tizen project

* Remove space

* Fix compatibility issue (#41)

* Fix compatibility issue

* Fix Compatibility Resource path

* Bump to latest

- Modal Navigation Manager (#1563)
- Implement the basic WindowHandler (#1468)
- Don't extract native defaults, meaning users can no longer reset a color back to a platform theme (#1485)
- Implement Alerts (Alert, Prompt and ActionSheet) (#1328)
- And so on.

* [SingleProject] Fix Issues (#50)

* Bumt to latest

- Effects (#1574)
- Improve Window and AnimationManager (#1653)
- and so on

* Add Microsoft.Maui.Graphics.Skia as PackageReference

* Add Essentials.Samples.Tizen (#24)

* Add Essentials.Samples.Tizen

* Add guard for null exception

* Fix Essentials.Samples for Tizen

* Fix csproj for net6

* Remove Forms.Init

* Fix build error (#60)

* Update referenced Tizen.UIExtensions version (#61)

* Add BlazorWebView skeleton code (#62)

* Bump to latest (#71)

- Window lifecycle (#1754)
- Move New Navigation Handler to Core and make it internal (#1800)
- Scrollview handler (#1669)
- ScrollView Resize + Window Handler Resize (#1676)
- Font AutoScalingEnabled (#1774)
- Rename Font Properties (#1755)
- Update layout system to ensure native measure/arrange are called for all controls, even from Page subclasses (#1819)
- IContainer as IList<IView> (#1724)
- Implement Layout padding for new StackLayouts and GridLayout (#1749)
- Delete all the TabIndex, TabStop, Focusable things! (#1777)
- Introduce SetSemanticFocus API via SemanticExtensions (#1829)
- Improve Window and AnimationManager (#1653)
- And so on

* Remove IPage on Tizen (#72)

- Merge IFrameworkElement and IView and Remove IPage (#1875)

* Add Blazor webview (#67)

* Add Blazor webview

* Replace space to tab

* remove space

* Fix entry cursor error (#68)

* Fix entry cursor error

* Update code referring to android extension

* Remove duplicate code & Add exception cases

* Code fixes for consistency

* Fix nullable issue (#77)

* Fix Image loading (#78)

* Fix nested layout issue (#79)

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <[email protected]>

* Fix issues caused by bump up (#75)

* Fix issues caused by bump up

* Update Tizen file provider

* Update file provider with proper path

* Fix unmatched partial method (#84)

* Fixes incorrect parameter type for ILayoutManager.ArrangeChildren (Rectangle -> Size). (#91)

* Make the HandlerToRendererShim simple

* Revert "Fixes incorrect parameter type for ILayoutManager.ArrangeChildren (Rectangle -> Size). (#91)" (#97)

This reverts commit c54ac83.

* Refactor the LayoutHandler (#99)

* Fix layout measure issue (#100)

* Fix LayoutHandler Update issue (#103)

* Fix LayoutHandler Update issue

* Implement InvalidateMeasure propagation

* Update MapBackground

* Add InitializationOptions (#107)

* Add InitializationOptions

* Set UseSkiaSharp true as default

* Apply DP as default

* Fix SKClipperView to have proper size (#115)

* Fix Essentials sample (#108)

* Fix Essentials sample for Tizen

* Remove UseSkiaSharp flag

* Remove MaterialComponents

* Fix Tizen flag

* Remove CustomRenderer

* Add ShellHandler (#64)

* Add ShellHandler

* Move ShellView into Platform/Tizen

* Update ShellView

* Move the code for embedded tizen resources to csproj

* Add UIExtenstions for shell

* MAUI workload for Tizen (#66)

* Fix build and runtime error after bumping to latest code

* Fix HandlerToRendererShim dispose (#127)

* Add ShellSearchView (#121)

* Add ShellSearchView

* Fix the layout issue in ShellSearchResultList

* Enable nullable

* Fix maximum height of ShellSearchResultList

* Fix scaling issue on Clip (#130)

* Fix DisplayResolutionUnit sync issue (#134)

* Fix build error (#137)

* Replace SkiaGraphicsView with local patch (#135)

This commit will be revert when upstream code is updated

* Support Min/Max Height/Width on IView and applying MauiApp/MauiAppBuilder pattern

- Support Min/Max Height/Width on IView (#2265)
- Updating .NET MAUI to use MauiApp/MauiAppBuilder pattern and use MS.Extensions.DependencyInjection (#2137)

* Fix Tizen Templates (#144)

* Fix webview break caused by updated dependency (#143)

* Update the Tizen.UIExtension.ElmSharp version (#145)

* Reomve internal UIExtensions compoments for Shell (#147)

* Adds missing implementation after bumping to latest main

* [Tizen] Adds BoxView Handler

* [Tizen] Implement ProgressColor property in ProgressBarHandlers

- Implement ProgressColor property in ProgressBarHandlers (#600)

* [Tizen] Handle ContentViews and templated content in new layout system

* Bump to latest (rc1)

- ImageButtonHandler and Handler Re-usability (#2352)
- Remove IBoxView (#2619)
- Add SupportedOSPlatformVersion (#2565)
- Merge all the .NET 6 projects/solutions (#2505)
- Shadow Support (#570)
- Add IndicatorView handler(#2038)

* [Tizen] Apply graphics related code review feedback

* [Tizen] Port H/V TextAlignment to Editor/Picker Handler

* [Tizen] Add TVShellView (#183)

* [Tizen] Add TVShellView

* [Tizen] Update TVShellView

* [Tizen] Update NativeView for Shell

* [Tizen] Update ShellView

* [Tizen] Change default FlyoutBackgroundColor for TV

* [Tizen] Enable nullable

* Refactor WrapperView to draw drawable features (#186)

* Refactor WrapperView to draw drawable features

* Update class names and devide files

* Override NeesContainer to remove duplicated code

* Update class names

* [Tizen] Adds ApplicationHandler

* Fix Background issue of Frame (#193)

* Fix UpdateBackground (#194)

* Fix UpdateBackground

* Add ContentView Background mapper

* Fix Editor/Entry/Label/Layout Background

* Add IWrapperViewCanvas.Content

* Add PageHandler Background mapper

* Restore WrapperView

* Remove unnecessary namespace

* [Tizen] Fix build error on PageHandler

* [Tizen] Apply ITextButton related changes

* [Tizen] Add Shadows (#233)

* [Tizen] Add Shadows

* [Tizen] Apply review comments

* [Tizen] Move updating shape in proper position

* [Tizen] Update BackgroundDrawable

* [Tizen] Apply review comments

* [Tizen] Add BorderDrawable (#224)

* Move to platform specific

* Fix border handler for Tizen

* Rename ToDrawable method

* Fix border content layout

* Fix BorderView

* Apply rebase

* [Tizen] Fix entry cursor issue (#222)

* Fix entry cursor issue

* Fix UpdateSelectionLength method

* [Tizen] Remove TVNavigationDrawer TVNavigationView (#223)

* [Tizen] Remove TVNavigationDrawer TVNavigationView

* [Elmsharp] Update Tizen.UIExtensions version

* [Tizen] Initial Multi Window support

* [Tizen] Fix MauiContext

* [Tizen] Refactor Border by defining MauiDrawable (#248)

* [Tizen] Refactor Border by defining MauiDrawable

* [Tizen] Apply review comments

* [Tizen] Remove unnecessary type casting

* [Tizen] Move getting path logic to drawable

* [Tizen] Obsolete AndExpand & Remove IsolatedStorage

* Fix tizen solution (.sln) correctly

* [Tizen] Add VerticalTextAlignment

* [Tizen] Fix Scoping of MauiContext

* [Tizen] Use CoreApplication as native app type

* [Tizen] Applying upstream changes

* [Tizen] Add ContainerView to Layout if it's present

* [Tizen] Initial Reloadyfy support

* [Tizen] Initial IVisualDiagnosticOveraly support

* [Tizen] Move types in the Platform folder into the Platform namespaces

* Fix CollectionView layout issue (#288)

* Fix CollectionView layout issue

* Remove unnecessary code

* [Tizen] ZIndex proof-of-concept

* Fix ScrollView ContentSize and Padding margin (#291)

* Fix ScrollView ContentSize and Padding margin

* Fix MapRequestScrollTo

* Update src/Core/src/Handlers/ScrollView/ScrollViewHandler.Tizen.cs

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <[email protected]>

* Update src/Core/src/Handlers/ScrollView/ScrollViewHandler.Tizen.cs

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <[email protected]>

* Remove MapContentSize

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <[email protected]>

* Implements WindowOverlay and VisualDiagnosticsOverlay (#294)

* Implements WindowOverlay and VisualDiagnosticsOverlay

* Apply code review

* [Tizen] Fix Image Handler

* Remove GetDesiredSize (#295)

* [Tizen] Fix ButtonHandler

* [Tizen] Organize and centralize HandlerExtensions

* Refactor WrapperView and Fix Issue (#302)

* Refactor WrapperView

* Use Thickness type for Shadow margin

* Update variable name

* Update class name to GraphicsExtensions

* Fix essentials sample for Tizen (#305)

* [Tizen] Fix NativeView casting issue

* Fix BlazorWebview binary resource issue (#317)

* [Tizen] Handle query strings in Blazor static assets by trimming them out

* Refactor MauiContext (#330)

* [Tizen] Adds PaintExtensions

* [Tizen] Implement CursorPosition in IEditor/ITextInput Handlers

* [Tizen] Remove GetNative

* [Tizen] Update Microsoft.NET.Sdk.Maui/WorkloadManifest

* [Tizen] Bump to latest

* [Tizen] Use legacy compat renderers temporarily

* [Tizen] Implement IPlatformApplication.Current

* [Tizen] Fix INativeViewHandler to return more expected NativeView

* [Tizen] Remove legacy TFMs

* [Tizen] Remove `IPlatformInvalidate` and `Device.Invalidate()

* [Tizen] Fix Essential sample build error

* [Tizen] Refactor Essential's implementations

* [Tizen] Renaming public APIs Native -> Platform

* [Tizen] Interfaced Handler for Label, Page, NavigationView, Picker,
ProgressBar, SwipeView

* [Tizen] Moved GetPlatformSize logic into a new service

* [Tizen] Interfaced handler for Switch, TimePicker, WebView, Slider,
SearchBar, RefreshView, RadioButton

* [Tizen] Fix build error after rebasing

* [Tizen] Move TabbedPageHandler to TabbedViewHandler

* [Tizen] Backport p14 changes

* [Tizen] Loaded/Unloaded events and propagate Window

* [Tizen] Implement FillRule property in Polygon/PolylineHandler

* [Tizen] Add install tizen to provision.yml

* [Tizen] Move package version into Versions.props

* Adds the Tizen backend

* [Tizen] Add Resizetizer Tizen Implementation

* Bump to latest and fix build error

* Bump to latest

- Apply to start adding in APIs for adding legacy renderers via assembly scanning (#1333)
- Update to IMauiContext (#1357)
- and so on

* Bump to latest

- Apply to patch related to Animation (#1436)
- Apply to register Microsoft.Maui.Graphics Platforms (#1441)
- and so on.

* Bump to latest

- Modal Navigation Manager (#1563)
- Implement the basic WindowHandler (#1468)
- Don't extract native defaults, meaning users can no longer reset a color back to a platform theme (#1485)
- Implement Alerts (Alert, Prompt and ActionSheet) (#1328)
- And so on.

* Bumt to latest

- Effects (#1574)
- Improve Window and AnimationManager (#1653)
- and so on

* Fix build error (#60)

* Bump to latest (#71)

- Window lifecycle (#1754)
- Move New Navigation Handler to Core and make it internal (#1800)
- Scrollview handler (#1669)
- ScrollView Resize + Window Handler Resize (#1676)
- Font AutoScalingEnabled (#1774)
- Rename Font Properties (#1755)
- Update layout system to ensure native measure/arrange are called for all controls, even from Page subclasses (#1819)
- IContainer as IList<IView> (#1724)
- Implement Layout padding for new StackLayouts and GridLayout (#1749)
- Delete all the TabIndex, TabStop, Focusable things! (#1777)
- Introduce SetSemanticFocus API via SemanticExtensions (#1829)
- Improve Window and AnimationManager (#1653)
- And so on

* Bump to latest

* Fix Essentials sample (#108)

* Fix Essentials sample for Tizen

* Remove UseSkiaSharp flag

* Remove MaterialComponents

* Fix Tizen flag

* Remove CustomRenderer

* Add ShellHandler (#64)

* Add ShellHandler

* Move ShellView into Platform/Tizen

* Update ShellView

* Move the code for embedded tizen resources to csproj

* Add UIExtenstions for shell

* MAUI workload for Tizen (#66)

* Fix build and runtime error after bumping to latest code

* Fix Essentials (#146)

* Fix Essentials sample for tizen

* Add SemanticScreenReader for Tizen

* Fix Startup

* Adds missing implementation after bumping to latest main

* Bump to latest (rc1)

- ImageButtonHandler and Handler Re-usability (#2352)
- Remove IBoxView (#2619)
- Add SupportedOSPlatformVersion (#2565)
- Merge all the .NET 6 projects/solutions (#2505)
- Shadow Support (#570)
- Add IndicatorView handler(#2038)

* Refactor WrapperView to draw drawable features (#186)

* Refactor WrapperView to draw drawable features

* Update class names and devide files

* Override NeesContainer to remove duplicated code

* Update class names

* [Tizen] Adds ApplicationHandler

* Fix UpdateBackground (#194)

* Fix UpdateBackground

* Add ContentView Background mapper

* Fix Editor/Entry/Label/Layout Background

* Add IWrapperViewCanvas.Content

* Add PageHandler Background mapper

* Restore WrapperView

* Remove unnecessary namespace

* [Tizen] Add BorderDrawable (#224)

* Move to platform specific

* Fix border handler for Tizen

* Rename ToDrawable method

* Fix border content layout

* Fix BorderView

* Apply rebase

* [Tizen] Refactor Border by defining MauiDrawable (#248)

* [Tizen] Refactor Border by defining MauiDrawable

* [Tizen] Apply review comments

* [Tizen] Remove unnecessary type casting

* [Tizen] Move getting path logic to drawable

* [Tizen] Fix Scoping of MauiContext

* [Tizen] Applying upstream changes

* [Tizen] Move types in the Platform folder into the Platform namespaces

* [Tizen] Fix ButtonHandler

* [Tizen] Organize and centralize HandlerExtensions

* Refactor MauiContext (#330)

* Add NUI handler

* [Tizen] Refactor MauiApplication and MauiContext (#216)

* Add AlertManager (#214)

* Code clean up (#218)

* Fix build error on Controls.Sample (#225)

* [Tizen] Initail CollectionViewHandler for NUI

* Fix PlatformEffect NativeView type (#231)

* Fix Control.Sample correctly (#234)

* Fix NamedSize (#242)

* Update NavigationPageRenderer (#238)

- Implement title view

* Fix build errors and apply upstream changes

* Refactoring Window and modal (#246)

* Obsolete AndExpand & fix build eror

* [NUI] Implement BlazorWebView (#259)

* Implement BlazorWebView

* Update NUI WebView alias name

* Bump to latest

* Fix MinimumWidth/Height MaximumWidth/Height (#270)

* [NUI] Add GestureManager (#272)

* Add gesture handler

* enable nullable

* use lazy

* Remove unnessary EFL code in ScrollViewHandler (#274)

* Add TabbedPage Renderer (#275)

* [NUI] Implement WrapperView enabling Border and Shadow (#273)

* [NUI] Add MauiDrawable enabling Border and Shadow

* [NUI] Remove BorderView type and refactor

* Refactor StrokeExtensions

* Remove unnecessary code

* Update a way clearing content

* [NUI] Add Picker handler (#276)

* Add Picker handler

* Apply code review

* Change timing adding event handler

* Update Picker on touch (#293)

* Fix NeedsContainer (#306)

* Update FrameRenderer to support Brush (#309)

* Fix minor layout issue (#314)

* Fix build error

* Fix ScrollView ContentSize (#324)

* Refactor Maui context (#328)

* Fix build error after bumping to latest

* [Tizen] Add ImageButtonHandler (#334)

* [NUI] Implement Editor/Entry handler (#335)

* Implement Editor/Entry handler

* Fix measure issue

* Update paramer name

* Fix if statement

* Fix Editor/Entry CursorPosition issue (#336)

* [NUI] Add CollectionViewHandler (#352)

* Fix EmptyView on CollectionView

* Add CollectionViewHandler

* Add SearchBar handler (#354)

* Implement Clip (#384)

* Bump to latest

* [NUI] Add TimePickerHandler (#390)

* [NUI] Add TimePickerHandler

* Update button placement

* Clean up code after rebase (#399)

* Fix TabbedPage to use Controls.Grid instead Compatibility.Grid (#400)

* Fix Controls MapText (#406)

* Fix focus management (#407)

* Update WrapperView (#409)

* Update Tizen platform to tizen10.0 (#416)

* Update WebView handler and MauiWebView handler (#417)

* Update Label shadow (#420)

* Fix build error after rebase

* Fix InputTransparent (#424)

* Implement CarouselView handler (#428)

* Fix GestureManager crash issue (#432)

* Update WebView EvaluateJavaScript async (#435)

* Fix CascadeInputTransparent (#442)

* Add NavigationView handler (#449)

* Update WindowOverlay handler (#452)

* Update ViewExtensions (#455)

* Update ImageSourceService (#454)

* Fix MauiSearchBar IsEnabled property (#458)

* Add SwipeView handler (#460)

* Clean code after rebase

* Fix GetPath to return a correct path (#465)

* Update for focus navigation (#459)

* Cleanup code after rebase

* Fix build error after rebase

* Implement UpdateBackgroundImageSourceAsync extensions method (#479)

* [NUI] Update SliderHandler with NUI slider component (#487)

* Update SliderHandler with NUI compnent

* Update SliderHandler with review feedback

* Update with review feedback

* Fix GetPlatformViewBounds as Pixel coordinate (#488)

* Fix ScrollView content size update issue (#492)

* Implement Controls.Compatibility for tizen (#493)

* Optimize Layout Measure (#495)

* Code cleanup after code rebase

* Fix z-order on Layout (#497)

* [NUI] Update StepperHandler (#498)

* Update StepperHandler

* Apply Review comment

* Fix Frame measure (#501)

* Fix BorderView (#500)

* Add RadioButton handler (#499)

* Fix CollectionView Item measure (#502)

* Fix Measure contraint convert (#504)

* Fix WrapperView measure (#507)

* Implement Missing mapper (#509)

* Fix WrapperView Width/HeightSpecification (#510)

* Fix ShapeView (#511)

* Optimize View measure (#513)

* Fix NavigationPage disposing pages (#514)

* Fix build error after rebase

* Fix WebView (#515)

* Fix TableView (#516)

* Fix Compatibility Cell templates (#517)

* [NUI] Add IndicatorViewHandler (#518)

* Add IndicatorViewHandler

* Update review comment

* Add space

* Fix ListViewRenderer (#519)

* Fix Binding error on CollectionView (#520)

* Fix layout issue when view was shown from hide (#522)

* [NUI] Fix ImageButton Clicked (#523)

* Fix ImageButton Clicked

* Apply review comment

* Fix BlazorWebView RequestIntercept issue (#524)

* Fix Layout size issue (#525)

* Fix build error after rebase

* [NUI] Add DatePicker Handler (#528)

* Add DatePicker

* Add missing class

* Update Style and Use DummyPopupPage

* Refactoring with MauiTimePicker

* add new file

Co-authored-by: Jay Cho <[email protected]>

* Fix GetBoundingBox/OverlayWindow touch point coordinate to DP (#529)

* Fix CollectionView EmptyView HeaderFooter (#530)

* Update DateTimePicker width on horizontal (#531)

* Fix DisconnectHandler (#532)

* Update Page default background color (#533)

* Clean up NuGet.config (#535)

* [NUI] Update font size (#536)

* Update FontNamedSize

* adjust font size on tv profile

* Add RefreshViewHandler (#490)

* [Tizen] Refactor compat renderers (#538)

* [Tizen] Refactor the TabbedPageRenderer (#541)

* [Tizen] Add FlyoutViewHandler (#540)

* Add FlyoutView

* Update FlyoutView to cover TV drawer

* Add missing connecting handler

* Update handler implementation using extensions

* Simplify code

Co-authored-by: Jay Cho <[email protected]>

* [Tizen] Add MauiPicker (#543)

* Add MenuIcon to Toolbar (#542)

* Add MenuIcon to Toolbar

* Apply Reviews

Co-authored-by: Jay Cho <[email protected]>

* [Tizen] Add ShellHandler (#539)

* [NUI] Add ShellHandler

* Update PublicAPI.Shipped.txt file

* Fix build error

* Update AppHostingBuilder

* Update ShellView with review feedback

* Remove unnecessary code

* Update Shell navigation stack

* Add IDisposable interface

* Update ShellSectionView

* Update AdppHostBuilderExtensions

* Rebase and update toolbar to resolve conflict

* Remove ShellContentHandler and update ToolbarHandler

* Update ShellView to handle DrawerToggleVisible

* Remove unnecessary code

* Fix build error after rebase

Co-authored-by: Kangho Hur <[email protected]>
Co-authored-by: 조중현/Common Platform Lab(SR)/Engineer/삼성전자 <[email protected]>
Co-authored-by: 김성수/Common Platform Lab(SR)/Staff Engineer/삼성전자 <[email protected]>
Co-authored-by: 박인서/Common Platform Lab(SR)/Associate/삼성전자 <[email protected]>
Co-authored-by: 민성현/Common Platform Lab(SR)/Staff Engineer/삼성전자 <[email protected]>
Co-authored-by: Jay Cho <[email protected]>
@samhouts samhouts added legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-core-hosting Extensions / Hosting / AppBuilder / Startup area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter area-controls-button Button, ImageButton area-controls-editor Editor area-controls-entry Entry area-controls-label Label, Span labels Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho left review comments

@PureWeen PureWeen Awaiting requested review from PureWeen

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz

Assignees
No one assigned
Labels
area-controls-button Button, ImageButton area-controls-editor Editor area-controls-entry Entry area-controls-label Label, Span area-controls-progressbar ProgressBar area-controls-slider Slider area-controls-switch Switch area-core-hosting Extensions / Hosting / AppBuilder / Startup area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter platform/android 🤖 platform/iOS 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattleibow @Codelisk @rmarinho @Eilon @samhouts