Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TitleView work in NavigationPage and Shell on Windows #5293

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Make TitleView work in NavigationPage and Shell on Windows #5293

merged 1 commit into from
Mar 15, 2022

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Mar 15, 2022 •
edited
Loading

Description of Change

TitleView for NavigationPage on Windows:

<NavigationPage.TitleView>
    <Button Text="Title View Button" />
</NavigationPage.TitleView>

image

Issues Fixed

Totally fixes #1628
Fixes the Android and WinUI parts of #3877.

@Redth Redth self-assigned this Mar 15, 2022
@hartez hartez changed the title Make TitleView work in NavigationPage on Windows Make TitleView work in NavigationPage and Shell on Windows Mar 15, 2022
@hartez hartez mentioned this pull request Mar 15, 2022
Closed
@PureWeen PureWeen merged commit 108c81a into main Mar 15, 2022
@PureWeen PureWeen deleted the windows-navpage-titleview branch March 15, 2022 18:42
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen approved these changes

Assignees

@Redth Redth

Labels
area-navigation NavigationPage fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1! platform/windows 🪟
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WinUI, Shell] Implement TitleView #9808
5 participants
@hartez @PureWeen @Redth @jsuarezruiz @samhouts