-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1100-Enhancement-DatePicker-supports-nullable-(Selected)-Date #9727
1100-Enhancement-DatePicker-supports-nullable-(Selected)-Date #9727
Conversation
…r non user selected dates.
…e-(Selected)-Date
…nullable-(Selected)-Date
…nullable-(Selected)-Date
…)-Date' of https://github.com/davidbuckleyni/maui into 1100-Enhancement-DatePicker-supports-nullable-(Selected)-Date
…e-(Selected)-Date
Hey there @ryanwmitchell! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
@@ -126,7 +126,12 @@ void OnControlDateChanged(object sender, DatePickerValueChangedEventArgs e) | |||
if (Element == null) | |||
return; | |||
|
|||
if (Element.Date.CompareTo(e.NewDate.Date) != 0) | |||
var elementDate = Element.Date; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var elementDate = Element?.Date
if(elementDate == null)
return
Hey @ryanwmitchell thank you so much for doing this and sorry we didn't get to this earlier. I'm on this now! Are you still interested in taking this home? If so, let's work on it! If not, also fine, then I will take over and see if we can get it in a mergeable state. Thanks! |
No response and PR grew too stale to be recoverable at this point. Let's close it and revisit later. Thanks for the time and effort here! |
@jfversluis this is a much need thing on MAUI. A Nullable DatePicker is a must have for a lot of scenarios. Please raise a priority on it. |
Description of Change
Implements #
Additions made
PR Checklist
Does this PR touch anything that might affect accessibility?
If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.