Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1100-Enhancement-DatePicker-supports-nullable-(Selected)-Date #9727

Conversation

ryanwmitchell
Copy link

Description of Change

Implements #

Additions made

  • Adds

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@ghost ghost added the community ✨ Community Contribution label Aug 28, 2022
@ghost
Copy link

ghost commented Aug 28, 2022

Hey there @ryanwmitchell! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dnfadmin
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ ryanwmitchell sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@Eilon Eilon added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Aug 29, 2022
@@ -126,7 +126,12 @@ void OnControlDateChanged(object sender, DatePickerValueChangedEventArgs e)
if (Element == null)
return;

if (Element.Date.CompareTo(e.NewDate.Date) != 0)
var elementDate = Element.Date;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var elementDate = Element?.Date

if(elementDate == null)
return

@jfversluis jfversluis self-assigned this Feb 13, 2023
@jfversluis
Copy link
Member

Hey @ryanwmitchell thank you so much for doing this and sorry we didn't get to this earlier. I'm on this now!

Are you still interested in taking this home? If so, let's work on it! If not, also fine, then I will take over and see if we can get it in a mergeable state. Thanks!

@jfversluis
Copy link
Member

No response and PR grew too stale to be recoverable at this point. Let's close it and revisit later. Thanks for the time and effort here!

@jfversluis jfversluis closed this Mar 8, 2023
@eder-careplus
Copy link

@jfversluis this is a much need thing on MAUI. A Nullable DatePicker is a must have for a lot of scenarios. Please raise a priority on it.

@acaliaro acaliaro mentioned this pull request Jun 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
@Eilon Eilon added area-controls-datetimepicker DatePicker, TimePicker and removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-datetimepicker DatePicker, TimePicker community ✨ Community Contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants