-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CoreCrossTargetingTargetsPath import when SDK provides them via package mechanism #1062
Comments
@rainersigwald @AndyGerlicher Please assign this to me. Any chance I could get permission to do that myself? |
@nguerrera I think you might have permissions now. Maybe. |
Do we still need this? |
Technically, we could remove this: But it is a breaking change if anyone besides dotnet/sdk started using it. I think we could also leave it and remove the TODO. |
Looks like this is probably not used, at least in public code: https://github.com/search?q=CoreCrossTargetingTargetsPath+-filename%3AMicrosoft.Common.CrossTargeting.targets&type=code |
We'll, now's the time then. |
I already have it in my patch. I'll separate this into a new PR! |
Fixes #1062 ### Context The import based on this property was introduced as a temporary bootstrapping mechanism before there was packaging extensibility available for multi-targeting. The packaging mechanism (aka NuGet) now uses `buildCrossTargeting`/`buildMultiTargeting`, similar to `build` package folder to hold and import multi-targeting logic via NuGet's Restore. Thus, we don't need this workaround anymore. ### Changes Made Removed the temporary import based on `CoreCrossTargetingTargetsPath` ### Testing Since there are no tests for this property, as it is with all the workarounds… We'll see if we break anyone during the self-hosting period. ### Notes This patch was already a part of #6161. Since, the change was approved independently, I have separated this into a new PR.
Microsoft.Commmon.CrossTargeting.targets imported $(CoreCrossTargetingTargetsPath) as a temporary bootstrapping mechanism before there was packaging extensibility available for cross-targeting builds. Once the SDK targets are successfully wired in via the packaging mechanism, remove this import.
The text was updated successfully, but these errors were encountered: