Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wasm/WASI tasks spec #10259

Merged
merged 15 commits into from
Aug 12, 2024
Merged

Wasm/WASI tasks spec #10259

merged 15 commits into from
Aug 12, 2024

Conversation

JanProvaznik
Copy link
Contributor

@JanProvaznik JanProvaznik commented Jun 18, 2024 •
edited
Loading

This is a PR for the proposed WASI-Build feature spec, only documentation

WIP implementation: https://github.com/JanProvaznik/MSBuildWasm

@JanProvaznik JanProvaznik added Area: Tasks Issues impacting the tasks shipped in Microsoft.Build.Tasks.Core.dll. WIP labels Jun 18, 2024
@JanProvaznik JanProvaznik self-assigned this Jun 18, 2024
rainersigwald
rainersigwald reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I've got LOTS of comments here but this is great progress and I'm getting even more excited about the project. Feel free to reach out to discuss anything.

documentation/specs/proposed/WASI-tasks.md Outdated Show resolved Hide resolved
documentation/specs/proposed/WASI-tasks.md Outdated Show resolved Hide resolved
documentation/specs/proposed/WASI-tasks.md Outdated Show resolved Hide resolved
documentation/specs/proposed/WASI-tasks.md Outdated Show resolved Hide resolved
documentation/specs/proposed/WASI-tasks.md Outdated Show resolved Hide resolved
documentation/specs/proposed/WASI-tasks.md Outdated Show resolved Hide resolved
documentation/specs/proposed/WASI-tasks.md Outdated Show resolved Hide resolved
documentation/specs/proposed/WASI-tasks.md Outdated Show resolved Hide resolved
documentation/specs/proposed/WASI-tasks.md Outdated Show resolved Hide resolved
documentation/specs/proposed/WASI-tasks.md Outdated Show resolved Hide resolved
@JanProvaznik JanProvaznik changed the base branch from main to feature/wasi-tasks June 20, 2024 14:49
YuliiaKovalova
YuliiaKovalova reviewed Jun 27, 2024
View reviewed changes
documentation/specs/proposed/WASI-tasks.md Outdated Show resolved Hide resolved
documentation/specs/proposed/WASI-tasks.md Outdated Show resolved Hide resolved
documentation/specs/proposed/WASI-tasks.md Outdated Show resolved Hide resolved
@JanProvaznik
add API specification in WIT
4e4aeff 
clarify spec, update with info about communication between host and tasks
@JanProvaznik
rename to Wasm-tasks
42d1f06
@JanProvaznik JanProvaznik changed the title WASI-Build spec Wasm-Build spec Jul 1, 2024
@JanProvaznik JanProvaznik mentioned this pull request Jul 2, 2024
Closed
@JanProvaznik JanProvaznik changed the title Wasm-Build spec Wasm/WASI tasks spec Jul 12, 2024
@JanProvaznik JanProvaznik removed the WIP label Jul 15, 2024
@JanProvaznik JanProvaznik marked this pull request as ready for review July 15, 2024 13:00
@JanProvaznik JanProvaznik changed the base branch from feature/wasi-tasks to main July 15, 2024 13:00
YuliiaKovalova
YuliiaKovalova approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@YuliiaKovalova YuliiaKovalova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, some small comments to consider

documentation/specs/proposed/Wasm-tasks.md Outdated Show resolved Hide resolved
documentation/specs/proposed/Wasm-tasks.md Outdated Show resolved Hide resolved
documentation/specs/proposed/Wasm-tasks.md Outdated Show resolved Hide resolved
documentation/specs/proposed/Wasm-tasks.md Show resolved Hide resolved
documentation/specs/proposed/Wasm-tasks.md Outdated Show resolved Hide resolved
rainersigwald
rainersigwald approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving it!

documentation/specs/proposed/Wasm-tasks.md Outdated Show resolved Hide resolved
documentation/specs/proposed/Wasm-tasks.md Outdated Show resolved Hide resolved
documentation/specs/proposed/Wasm-tasks.md Outdated Show resolved Hide resolved
documentation/specs/proposed/wasmtask.wit Outdated Show resolved Hide resolved
@rainersigwald
Copy link
Member

@lambdageek @lewing y'all might be interested in this project.

@JanProvaznik
add links to docs, address feedback
e093d91 
format and fix WIT so it can generate bindings
@YuliiaKovalova YuliiaKovalova merged commit 0716e1c into dotnet:main Aug 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cataggar cataggar cataggar left review comments

@rainersigwald rainersigwald rainersigwald approved these changes

@heaths heaths heaths left review comments

@pavelsavara pavelsavara pavelsavara left review comments

@YuliiaKovalova YuliiaKovalova YuliiaKovalova approved these changes

@baronfel baronfel Awaiting requested review from baronfel

Assignees

@JanProvaznik JanProvaznik

Labels
Area: Tasks Issues impacting the tasks shipped in Microsoft.Build.Tasks.Core.dll.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JanProvaznik @rainersigwald @pavelsavara @baronfel @heaths @cataggar @YuliiaKovalova