[Static Graph] ProjectGraph.GetTargetLists throws on invalid target names #4599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdmihai
force-pushed
the
clarifyDocumentation
branch
from
7cb8cba
to
bdad502
Compare
cdmihai
force-pushed
the
clarifyDocumentation
branch
from
bdad502
to
3e0fe7e
Compare
| } | ||
|
|
||
| [Fact] | ||
| public void GetTargetListsReturnsEmptyTargetsForAllNodesWhenDefaultTargetsAreRequestedAndThereAreNoDefaultTargets() |
There was a problem hiding this comment.
Under what circumstance are there no default targets? Doesn't MSBuild always have a default target (if none is explicitly listed, it's the first one defined in the logical project)?
There was a problem hiding this comment.
The project file has no targets. Added a comment on it.
|
|
||
| if (targetNames.Any(targetName => string.IsNullOrWhiteSpace(targetName))) | ||
| { | ||
| throw new ArgumentException(ResourceUtilities.FormatResourceStringIgnoreCodeAndKeyword("OM_TargetNameNullOrEmpty", nameof(GetTargetLists))); |
There was a problem hiding this comment.
Is this enough context? I was thinking more along the lines of "what project caused this error?"
There was a problem hiding this comment.
Ah, that's a bit harder to answer. There is no actual project here. These targets are the graph wide targets the whole graph needs to be built with. The closest thing for identification would be the set of graph roots
rainersigwald
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just cleanup: clarifying some documentation, validating some inputs, avoiding needless iterations.