-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release branding for 16.3 #4684
Conversation
We also can't do this until we've gotten release-branded CoreFX, because of this error:
|
Hum, it seems like we will then have to insert msbuild along with the SDK into VS then. As the whole thing will have to be final. |
Got it. Yeah, hold off on this until we verify that we won't accidentally publish the final bits to public feeds. |
@rainersigwald is the corefx package that msbuild depends on an OOB package? |
@ericstj is |
Define OOB. It is a package that can work on more than just .NETCore. It carries a .NETStandard implementation. It builds out of corefx and versions with the product. Just like every other package in CoreFx (eg: System.Reflection.Metadata, System.Collections.Immutable, etc). Let me know if this answers your question or not. |
Yep. It was a question of whether they should be depending on this package in context of Microsoft.NETCore.App. This is fine as it is. |
Yeah, it's not part of the base shared framework so they need the dependency. |
We now have a stable version for these dependencies. @mmitche will push the packages to the feed. |
Holding off on this until I get a quick arcade update to ensure no accidental stable publishing |
We shouldn't merge this until we're ready, as every change after that will require a manual version bump.