Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release branding for 16.3 #4684

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Conversation

rainersigwald
Copy link
Member

@rainersigwald rainersigwald commented Aug 30, 2019

We shouldn't merge this until we're ready, as every change after that will require a manual version bump.

@rainersigwald rainersigwald added this to the MSBuild 16.3 milestone Aug 30, 2019
@rainersigwald
Copy link
Member Author

We also can't do this until we've gotten release-branded CoreFX, because of this error:

error NU5104: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "System.Resources.Extensions [4.6.0-preview9.19416.11, )" or update the version field in the nuspec.

@livarcocc
Copy link
Contributor

Hum, it seems like we will then have to insert msbuild along with the SDK into VS then. As the whole thing will have to be final.

cc @mmitche @johnbeisner

@mmitche
Copy link
Member

mmitche commented Sep 4, 2019

Got it. Yeah, hold off on this until we verify that we won't accidentally publish the final bits to public feeds.

@mmitche
Copy link
Member

mmitche commented Sep 4, 2019

@rainersigwald is the corefx package that msbuild depends on an OOB package?

@rainersigwald
Copy link
Member Author

@ericstj is System.Resources.Extensions an OOB package?

@ericstj
Copy link
Member

ericstj commented Sep 4, 2019

Define OOB. It is a package that can work on more than just .NETCore. It carries a .NETStandard implementation. It builds out of corefx and versions with the product. Just like every other package in CoreFx (eg: System.Reflection.Metadata, System.Collections.Immutable, etc). Let me know if this answers your question or not.

@mmitche
Copy link
Member

mmitche commented Sep 4, 2019

Define OOB. It is a package that can work on more than just .NETCore. It carries a .NETStandard implementation. It builds out of corefx and versions with the product. Just like every other package in CoreFx (eg: System.Reflection.Metadata, System.Collections.Immutable, etc). Let me know if this answers your question or not.

Yep. It was a question of whether they should be depending on this package in context of Microsoft.NETCore.App. This is fine as it is.

@ericstj
Copy link
Member

ericstj commented Sep 4, 2019

Yeah, it's not part of the base shared framework so they need the dependency.

@livarcocc
Copy link
Contributor

We now have a stable version for these dependencies.

@mmitche will push the packages to the feed.

@livarcocc livarcocc marked this pull request as ready for review September 13, 2019 20:44
@mmitche
Copy link
Member

mmitche commented Sep 13, 2019

Holding off on this until I get a quick arcade update to ensure no accidental stable publishing

@mmitche mmitche merged commit 0f4c62f into dotnet:vs16.3 Sep 13, 2019
@rainersigwald rainersigwald deleted the 16.3-rtm-branding branch September 17, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants