Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept source build patches #4710

Merged
merged 2 commits into from
Sep 10, 2019
Merged

Accept source build patches #4710

merged 2 commits into from
Sep 10, 2019

Conversation

nguerrera
Copy link
Contributor

Clean git am -3 of https://github.com/dotnet/source-build/tree/4d680d106b9987ef28c66cc3491e88714fcffbe9/patches/msbuild

  1. Skip building for netfx in source build
  2. Build localization package in source build

cc @NikolaMilosavljevic @dseefeld @crummel

Fix #4589
Fix #4428

@nguerrera nguerrera added this to the MSBuild 16.4 milestone Sep 10, 2019
This was referenced Sep 10, 2019
Closed
Merged
@crummel
Copy link
Contributor

crummel commented Sep 10, 2019

Thanks for getting these in!

@nguerrera nguerrera merged commit 30da325 into dotnet:master Sep 10, 2019
@nguerrera nguerrera deleted the accept-source-build-patches branch September 10, 2019 20:24
@rainersigwald rainersigwald mentioned this pull request Oct 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes

@livarcocc livarcocc Awaiting requested review from livarcocc

@benvillalobos benvillalobos Awaiting requested review from benvillalobos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MSBuild 16.4
Development

Successfully merging this pull request may close these issues.

[Source Build] Add Microsoft.Build.Localization Source-build patch removal for MSBuild
5 participants
@nguerrera @crummel @rainersigwald @NikolaMilosavljevic @dseefeld