Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding xsd properties for AssetTargetFallback and Nullable. #4840

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Adding xsd properties for AssetTargetFallback and Nullable. #4840

merged 2 commits into from
Oct 22, 2019

Conversation

livarcocc
Copy link
Contributor

Fixes #4391 and #3292

@livarcocc livarcocc added this to the MSBuild 16.4 milestone Oct 22, 2019
Forgind
Forgind approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This allows people to use those properties but doesn't actually change what they do, correct?

rainersigwald
rainersigwald approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you know, but this will need to be synced to the internal VS repo.

src/MSBuild/Microsoft.Build.CommonTypes.xsd Outdated Show resolved Hide resolved
src/MSBuild/Microsoft.Build.CommonTypes.xsd Outdated Show resolved Hide resolved
src/MSBuild/Microsoft.Build.CommonTypes.xsd Outdated Show resolved Hide resolved
src/MSBuild/Microsoft.Build.CommonTypes.xsd Outdated Show resolved Hide resolved
src/MSBuild/Microsoft.Build.CommonTypes.xsd Outdated Show resolved Hide resolved
@jcouv
Copy link
Member

jcouv commented Oct 22, 2019

nullable section LGTM modulo typo that Rainer already identified. Thanks!

@livarcocc livarcocc merged commit 72f86ff into dotnet:master Oct 22, 2019
@livarcocc livarcocc deleted the add_more_xsd_properties branch October 22, 2019 21:59
@rainersigwald rainersigwald mentioned this pull request Jul 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes

@Forgind Forgind Forgind approved these changes

@benvillalobos benvillalobos Awaiting requested review from benvillalobos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MSBuild 16.4
Development

Successfully merging this pull request may close these issues.

Nullable properties in XSD
4 participants
@livarcocc @jcouv @rainersigwald @Forgind