Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to transitively copying content items #6622

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Default to transitively copying content items #6622

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c490d9
Default to transitively copying content items
benvillalobos Jun 23, 2021
f69f524
Update src/Tasks/Microsoft.Common.CurrentVersion.targets
benvillalobos Jun 24, 2021
121d477
Add PR to change wave doc
benvillalobos Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Tasks/Microsoft.Common.CurrentVersion.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4735,9 +4735,10 @@ Copyright (C) Microsoft Corporation. All rights reserved.
GetCopyToOutputDirectoryItems depends on an unspecified dependency _SplitProjectReferencesByFileExistence -> AssignProjectConfiguration (https://github.com/microsoft/msbuild/issues/4677).
When the unspecified dependency does not happen by accident, content copying is only 1 level deep instead of transitive.
This target enforces the dependency.

TODO: make transitive content copying the default when the breaking change is acceptable.
-->

<MSBuildCopyContentTransitively Condition=" '$(MSBuildCopyContentTransitively)' == '' and $([MSBuild]::AreFeaturesEnabled('17.0'))">true</MSBuildCopyContentTransitively>

<_TargetsThatPrepareProjectReferences Condition=" '$(MSBuildCopyContentTransitively)' == 'true' ">
AssignProjectConfiguration;
_SplitProjectReferencesByFileExistence
Expand Down