Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description about transitive copying #6703

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

benvillalobos
Copy link
Member

Fixes #943

Context

The description for the target GetCopyToOutputDirectoryItems was incorrect. This fixes that due to #6622


As of 17.0, content items are copied transitively by default.
Set `MSBuildCopyContentTransitively` to false to opt out.
See https://github.com/dotnet/msbuild/pull/6622 for more info.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nit:

Suggested change
See https://github.com/dotnet/msbuild/pull/6622 for more info.
See https://github.com/dotnet/msbuild/pull/6622 for more details.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have a doc page for this. Can you work with @ghogen to create one/make sure it's up to date?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the documentation is still outdated here. @eerhardt @ghogen Could you update the documentation?


As of 17.0, content items are copied transitively by default.
Set `MSBuildCopyContentTransitively` to false to opt out.
See https://github.com/dotnet/msbuild/pull/6622 for more info.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have a doc page for this. Can you work with @ghogen to create one/make sure it's up to date?

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Jul 31, 2021
@rokonec rokonec merged commit b7eb19b into dotnet:main Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetCopyToOutputDirectoryItems says it doesn't work for transitive P2P references
5 participants