Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub now [generates navigation options][1] in Markdown files, so no need to have them here manually. [1]: https://github.blog/changelog/2021-04-13-table-of-contents-support-in-markdown-files/
Forgind
approved these changes
Aug 13, 2021
Forgind
added
the
merge-when-branch-open
ladipro
approved these changes
Aug 16, 2021
AR-May
approved these changes
Aug 16, 2021
benvillalobos
approved these changes
Aug 16, 2021
There was a problem hiding this comment.
I'm a bit split because I like getting rid of unnecessary things, but it's really easy to see this table of contents, whereas the built-in version is hard to notice if you don't already know about it. Probably fine, though.
I had the same thought almost verbatim.
|
I think they should be deleted because
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub now generates navigation options in Markdown files, so no need to have them here manually.