Revert MSBuildDebugEngine #6787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngine; Inject binary logger from BuildManager; print static graph as .dot file (dotnet#6639)" This reverts commit cdb5077. Conflicts: documentation/wiki/ChangeWaves.md src/Build/BackEnd/Components/Scheduler/Scheduler.cs src/Shared/Traits.cs
Forgind
approved these changes
Aug 27, 2021
benvillalobos
approved these changes
Aug 27, 2021
Forgind
added
the
merge-when-branch-open
|
Closing this because we decided to try fixing forward in #6792. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cdb5077.
Conflicts:
documentation/wiki/ChangeWaves.md
src/Build/BackEnd/Components/Scheduler/Scheduler.cs
src/Shared/Traits.cs
Fixes a few issues that have cropped up, see #6639 (comment) and some internal Teams conversations.
I have no objection to bringing back the bulk of the change after we figure out the problems--and I believe they're all related to changing the stack-dump directory.