-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enumeration values for DebugType in XSD #6849
Conversation
Also document that pdbonly is the same as full in recent compilers, as documented in https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-options/code-generation#debugtype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We're past localization freeze in our repo but not VS where this will actually be localized so we can take this for 17.0.
Can we get a quick look from someone on @dotnet/roslyn-compiler, since this is a C#/VB option?
@rainersigwald I'll leave it to you good folks to determine when this should be merged. Thanks. |
@drewnoakes The test failures look legitimate to me--they're in XSD validation. Can you take a look please? |
This code has been commented out since time immemorial: msbuild/src/MSBuild.UnitTests/ProjectSchemaValidationHandler_Tests.cs Lines 187 to 192 in f566ba1
But if it wasn't, you would have gotten this test error instead of "expected true" or whatever:
|
Pushed a fix. |
Co-authored-by: Forgind <[email protected]>
Context
The
DebugType
property has a set of expected values, and is not just a plain text property.Currently completion on the
DebugType
property offers no guidance:Changes Made
This change adds those values so they appear in completion. It also documents that
pdbonly
is equivalent tofull
in recent compilers.Testing
None.
Notes
None.