Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Windows Forms specific props #6860

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Sep 16, 2021

Resolves #6858

Context

Add new properties introduced in https://github.com/dotnet/designs/blob/main/accepted/2021/winforms/streamline-application-bootstrap.md#msbuild-properties

Test

Tested by updating the local version in C:\Program Files\Microsoft Visual Studio\2022\Preview\Xml\Schemas\1033\MSBuild and verifying in VS

image
image
image

@RussKie RussKie self-assigned this Sep 16, 2021
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good but since they are winforms-specific and our XSD isn't aware of that can you add something along the lines of "Applies only to Windows Forms projects" in each documentation?

@rainersigwald rainersigwald added this to the MSBuild 17.0 milestone Sep 16, 2021
@RussKie RussKie force-pushed the fix_6858_new_Windows_Forms_properties branch from 1847cb6 to a9f6b04 Compare September 17, 2021 01:34
@RussKie
Copy link
Member Author

RussKie commented Sep 17, 2021

Updated

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Sep 17, 2021
@AR-May AR-May merged commit 9b5ccf0 into main Sep 20, 2021
@RussKie RussKie deleted the fix_6858_new_Windows_Forms_properties branch September 20, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new properties to Windows Forms types schema
4 participants