Log explicit failure for LC on Core #7068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't going to be supported per dotnet/winforms#1462.
rainersigwald
added
.NET Core
Area: Tasks
|
What's the advantage to this? It seems like it changes an error because LC isn't available on Core into an error because LC isn't available on Core. |
|
It changes an incomprehensible error that LC isn't available on Core to an error that clearly says LC isn't available on Core. This is the pattern we've adopted for several tasks that don't have porting plans. |
RussKie
approved these changes
Nov 23, 2021
Forgind
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't going to be supported per dotnet/winforms#1462.