-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ConfigurationManager to Version.Details #8818
add ConfigurationManager to Version.Details #8818
Conversation
@rainersigwald soft ping - would be great if you could take a look at this small PR for source-build. Thank you for your time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have several other runtime dependencies that feel like they might be similar. Should they be added here? If not, how can we tell?
Lines 29 to 43 in f3dcaf7
<SystemCollectionsImmutableVersion>7.0.0</SystemCollectionsImmutableVersion> | |
<SystemConfigurationConfigurationManagerVersion>7.0.0</SystemConfigurationConfigurationManagerVersion> | |
<!-- | |
Modifying the version of System.Memory is very high impact and causes downstream breaks in third-party tooling that uses the MSBuild API. | |
When updating the version of System.Memory file a breaking change here: https://github.com/dotnet/docs/issues/new?assignees=gewarren&labels=breaking-change%2CPri1%2Cdoc-idea&template=breaking-change.yml&title=%5BBreaking+change%5D%3A+ | |
and follow the guidelines written here (internal-link): https://dev.azure.com/devdiv/DevDiv/_wiki/wikis/DevDiv.wiki/1796/How-to-add-a-Known-Issue | |
--> | |
<SystemMemoryVersion>4.5.5</SystemMemoryVersion> | |
<SystemNetHttpVersion>4.3.4</SystemNetHttpVersion> | |
<SystemReflectionMetadataLoadContextVersion>7.0.0</SystemReflectionMetadataLoadContextVersion> | |
<SystemReflectionMetadataVersion>7.0.0</SystemReflectionMetadataVersion> | |
<SystemResourcesExtensionsPackageVersion>7.0.0</SystemResourcesExtensionsPackageVersion> | |
<SystemSecurityPermissionsVersion>7.0.0</SystemSecurityPermissionsVersion> | |
<SystemSecurityPrincipalWindowsVersion>5.0.0</SystemSecurityPrincipalWindowsVersion> | |
<SystemTextEncodingCodePagesVersion>7.0.0</SystemTextEncodingCodePagesVersion> |
In most cases addition of these kind of entries to Currently only |
Context
Contributes to dotnet/source-build#3043
Declaring the
System.Configuration.ConfigurationManager
dependency inVersion.Details.xml
will allow source-build to replace the currently used7.0.0
version with then-1
version coming from previously source-built artifacts in the product / VMR build.Without this change, once repo PvP is enabled, the source-build of
msbuild
will fail in the product build.Changes Made
System.Configuration.ConfigurationManager: 7.0.0
toVersion.Details.xml
Testing
Notes