Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ConfigurationManager to Version.Details #8818

Conversation

oleksandr-didyk
Copy link
Contributor

Context

Contributes to dotnet/source-build#3043

Declaring the System.Configuration.ConfigurationManager dependency in Version.Details.xml will allow source-build to replace the currently used 7.0.0 version with the n-1 version coming from previously source-built artifacts in the product / VMR build.

Without this change, once repo PvP is enabled, the source-build of msbuild will fail in the product build.

Changes Made

  • added an entry for System.Configuration.ConfigurationManager: 7.0.0 to Version.Details.xml

Testing

Notes

@oleksandr-didyk
Copy link
Contributor Author

@rainersigwald soft ping - would be great if you could take a look at this small PR for source-build. Thank you for your time!

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have several other runtime dependencies that feel like they might be similar. Should they be added here? If not, how can we tell?

<SystemCollectionsImmutableVersion>7.0.0</SystemCollectionsImmutableVersion>
<SystemConfigurationConfigurationManagerVersion>7.0.0</SystemConfigurationConfigurationManagerVersion>
<!--
Modifying the version of System.Memory is very high impact and causes downstream breaks in third-party tooling that uses the MSBuild API.
When updating the version of System.Memory file a breaking change here: https://github.com/dotnet/docs/issues/new?assignees=gewarren&labels=breaking-change%2CPri1%2Cdoc-idea&template=breaking-change.yml&title=%5BBreaking+change%5D%3A+
and follow the guidelines written here (internal-link): https://dev.azure.com/devdiv/DevDiv/_wiki/wikis/DevDiv.wiki/1796/How-to-add-a-Known-Issue
-->
<SystemMemoryVersion>4.5.5</SystemMemoryVersion>
<SystemNetHttpVersion>4.3.4</SystemNetHttpVersion>
<SystemReflectionMetadataLoadContextVersion>7.0.0</SystemReflectionMetadataLoadContextVersion>
<SystemReflectionMetadataVersion>7.0.0</SystemReflectionMetadataVersion>
<SystemResourcesExtensionsPackageVersion>7.0.0</SystemResourcesExtensionsPackageVersion>
<SystemSecurityPermissionsVersion>7.0.0</SystemSecurityPermissionsVersion>
<SystemSecurityPrincipalWindowsVersion>5.0.0</SystemSecurityPrincipalWindowsVersion>
<SystemTextEncodingCodePagesVersion>7.0.0</SystemTextEncodingCodePagesVersion>

eng/Version.Details.xml Outdated Show resolved Hide resolved
@oleksandr-didyk
Copy link
Contributor Author

oleksandr-didyk commented Jun 7, 2023

We have several other runtime dependencies that feel like they might be similar. Should they be added here? If not, how can we tell?

In most cases addition of these kind of entries to Version.Details.xml is related to the dependency in question being loaded in during the build and source-build having a reference package for it, which causes a build failure. These can be unearth by simply building the repo / product.

Currently only System.Configuration.ConfigurationManager is causing problems. With the work for the issue mentioned in the PRs description complete, similar issues would be caught either in PRs to the repo or to installer. In .NET 9 timeframe, with the development of VMR, these issues would be caught in the repo PR only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants