Add helper for long StreamId keys #8578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you add a test to check that implicit subscription works with that? |
|
Added missing helpers for the GetStream methods. Regarding the unit tests I'm not sure where to put and how to implement them. Tried to follow existing tests that I found |
AdrianoAE
force-pushed
the
8577-streamid-long-key
branch
from
84186f3
to
07138d7
Compare
AdrianoAE
force-pushed
the
8577-streamid-long-key
branch
from
07138d7
to
5927645
Compare
|
@dotnet-policy-service agree |
benjaminpetit
approved these changes
Aug 21, 2023
|
Thanks @AdrianoAE ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8577
Microsoft Reviewers: Open in CodeFlow