Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address all IDE0032. Use auto-implemented property. #8614

Closed
wants to merge 5 commits into from
Closed

Address all IDE0032. Use auto-implemented property. #8614

wants to merge 5 commits into from

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Aug 31, 2023 •
edited by ghost
Loading

Supersedes part of #8471

Microsoft Reviewers: Open in CodeFlow

@IEvangelist IEvangelist mentioned this pull request Aug 31, 2023
Closed
@ReubenBond
Copy link
Member

Are these changes all generated automatically by code fixes? I need to work out what needs closer attention while reviewing and what doesn't. Eg, adding readonly to a field often results in the wrong behavior, so that will need special attention.

ReubenBond
ReubenBond reviewed Sep 1, 2023
View reviewed changes
Copy link
Member

@ReubenBond ReubenBond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some reversions needed, otherwise LGTM

@ghost ghost removed the Needs: author feedback label Sep 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ReubenBond ReubenBond ReubenBond left review comments

@pentp pentp pentp requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IEvangelist @ReubenBond @pentp