Address all IDE0251 warnings and naming inconsistencies. #8617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ReubenBond
reviewed
Sep 1, 2023
ReubenBond
approved these changes
Sep 1, 2023
IEvangelist
commented
Sep 1, 2023
pentp
reviewed
Sep 5, 2023
| private readonly INamedTypeSymbol? DateOnly; | ||
| private readonly INamedTypeSymbol DateTimeOffset; | ||
| private readonly INamedTypeSymbol? TimeOnly; | ||
| private INamedTypeSymbol _uri; |
There was a problem hiding this comment.
I don't think "fixing" these helped in any way. And why was readonly removed in the process?
| @@ -89,7 +89,7 @@ private void Resize(int sizeHint) | |||
| } | |||
|
|
|||
| /// <inheritdoc /> | |||
| public void Dispose() | |||
| public readonly void Dispose() | |||
There was a problem hiding this comment.
This is misleading and should be reverted - the struct is actually unusable after Dispose is called.
| @@ -178,13 +178,13 @@ public void Dispose() | |||
| /// Gets the position. | |||
| /// </summary> | |||
| /// <value>The position.</value> | |||
| public int Position => _previousBuffersSize + _bufferPos; | |||
| public readonly int Position => _previousBuffersSize + _bufferPos; | |||
There was a problem hiding this comment.
It's quite pointless to add readonly modifiers to methods on ref structs...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes part of #8471
Microsoft Reviewers: Open in CodeFlow