[Orleans.EventSourcing] Fix double-increment in RemoveStaleConditionalUpdates
#8623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
approved these changes
Jul 8, 2024
ReubenBond
changed the title
RemoveStaleConditionalUpdates
ReubenBond
force-pushed
the
fix/remove-stale-conditional-updates-issue
branch
from
23ea991
to
33c1920
Compare
ReubenBond
approved these changes
Jul 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The additional pos++ causes the loop to behave like pos += 2. Removing the additional pos++ so that each submission entry will be checked.
Microsoft Reviewers: Open in CodeFlow