build-server shutdown workaround #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrewScoggins
reviewed
Jun 5, 2020
| # shutdown_server(verbose=True) # This is the correct way to shut down dotnet build servers, but it has been disabled due to https://github.com/dotnet/sdk/issues/10573 | ||
| getLogger().info("Shutting down dotnet build servers...") | ||
| if util.iswin(): | ||
| os.system('TASKKILL /F /T /IM dotnet.exe || TASKKILL /F /T /IM VSTest.Console.exe || TASKKILL /F /T /IM msbuild.exe') |
There was a problem hiding this comment.
The || syntax means to only run the commands after it if the first one fails. Is that the behavior that we want?
There was a problem hiding this comment.
This command is suggested by @wli3 . I suppose the rationale here is dotnet.exe could be the parent process that spawns the other two, so if dotnet.exe has terminated we'd like to kill the child processes that are still running. Otherwise by specifying /T will be sufficient to kill the parent and child processes together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue can be found here: dotnet/sdk#10573