Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic FSharp benchmarks #1546

Closed
wants to merge 6 commits into from
Closed

Added basic FSharp benchmarks #1546

wants to merge 6 commits into from

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Oct 8, 2020

Adds FSharp benchmarks to the repo. Contains a simple 'hello world' compilation benchmark.

@TIHan
Copy link
Contributor Author

TIHan commented Mar 2, 2021

@billwert I need to fix a merge conflict, but is there anything else that I need to do here?

Copy link
Member

@billwert billwert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things:

  1. The pr.yml change may not be necessary. I pinged @DrewScoggins to see what he thinks.
  2. Can you explain what you're trying to accomplish with the 3.1 reference check? That will be problematic in our lab for two reasons. One, as you can see from the failures in CI it's going to fail in the release/5.0.1xx branch due to missing nuget paths (which is something that's not really fixable.) Second, we don't install a 3.1 .NET Core unless we're trying to run 3.1, so even if it had restored it would fail to execute. Depending on what you're trying to do we maybe can fix some of this, but it's better if we can just.. not. :)


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file is actually used - @DrewScoggins can you confirm?

@TIHan
Copy link
Contributor Author

TIHan commented Mar 3, 2021

@billwert I need to get a list of .NET Core DLL references in order to compile the benchmark test. I'm also fine just with testing .NET 5 and not .NET Core 3.1.

Base automatically changed from master to main March 18, 2021 17:12
@TIHan
Copy link
Contributor Author

TIHan commented Sep 20, 2021

Closing this as the scenarios trying to be addressed here require testing F# compiler APIs directly. Instead, we will just add F# scenarios in the "scenarios" folder of this repo.

@TIHan TIHan closed this Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants