-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We should be respecting $(ProjectAssetsFile) #1437
Comments
Something just occurred to me. @dsplaisted made changes so that SDK will not default ProjectAssetsFile and instead use what restore writes to generated temp props. Would this create a chicken-and-egg problem for initiating the watch when restore hasn't been done yet? |
@nguerrera Yes, this is a chicken and egg. If we can't find $(ProjectAssetsFile) we can't tell CPS that it needs to reevaluate. We were also planning to move to a model where CPS itself monitored the file based on https://github.com/dotnet/project-system/blob/master/src/Microsoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/DesignTimeTargets/Microsoft.Managed.DesignTime.targets#L281 but sounds like this would also be broken by that. |
:( |
I don't know how feasible this is, but I think the "right" thing to do would be to monitor the |
We already monitor the props/targets when we reevaluate and they appear, also wouldn't play nicely with shared intermediates. Was this change to remove logic from SDK? If so, can we add it back to NuGet targets? |
@davkean To clarify, will CPS detect when new .props / .targets files show up in the |
We don't monitor for props/targets existence under they appear in evaluation - there's thousand of locations they could appear. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
IFileWatchDataSource is a new feature that was added to unify the logic of re-revaluating a project based on external files (such as .editorconfig and project.assets.json). Plug in <AdditionalDesignTimeBuildInput /> items, of which project.assets.json is the only one. Fixes: dotnet#1437
IFileWatchDataSource is a new feature that was added to unify the logic of re-revaluating a project based on external files (such as .editorconfig and project.assets.json). Plug in <AdditionalDesignTimeBuildInput /> items, of which project.assets.json is the only one. Fixes: dotnet#1437
IFileWatchDataSource is a new feature that was added to unify the logic of re-revaluating a project based on external files (such as .editorconfig and project.assets.json). Plug in <AdditionalDesignTimeBuildInput /> items, of which project.assets.json is the only one. Fixes: dotnet#1437
IFileWatchDataSource is a new feature that was added to unify the logic of re-revaluating a project based on external files (such as .editorconfig and project.assets.json). Plug in <AdditionalDesignTimeBuildInput /> items, of which project.assets.json is the only one. Fixes: dotnet#1437
We find the assets files ourselves in the ProjectLockFileWatcher. We shouldn't be doing that, we should respecting $(ProjectAssetsFile).
See: NuGet/Home#4463 (comment)
The text was updated successfully, but these errors were encountered: