Add json.net dependency, fix incremental build #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,8 +7,9 @@ | |||
| <TargetPath></TargetPath> <!-- Prevent projects referencing this from trying to pass us to the compiler --> | |||
| </PropertyGroup> | |||
|
|
|||
| <Target Name="CoreCompile" /> <!-- Prevent Csc from being called --> | |||
| <Target Name="GenerateTargetFrameworkMonikerAttribute" /> <!-- Don't generate TFM attribute --> | |||
| <!-- Return this back when up-to-date bug is fixed (projects are being build everytime) --> | |||
There was a problem hiding this comment.
Is there a bug number tracking this?
There was a problem hiding this comment.
Incremental build is covered by: #62
|
👍 |
1 similar comment
|
👍 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small check in which adds a dependency on Json.Net 8.0.3. Also fixes the incremental compilation problem.
@abpiskunov @davkean