Added accessible name to AnalysisLevelComboBox. #6957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melytc
force-pushed
the
a11y-code-analysis
branch
from
08fb89d
to
27e0498
Compare
dmonroym
reviewed
Feb 11, 2021
src/Microsoft.VisualStudio.Editors/PropPages/CodeAnalysisPropPage.Designer.vb
Show resolved
Hide resolved
dmonroym
approved these changes
Feb 11, 2021
drewnoakes
reviewed
Feb 11, 2021
src/Microsoft.VisualStudio.Editors/PropPages/CodeAnalysisPropPage.resx
Outdated
Show resolved
Hide resolved
melytc
force-pushed
the
a11y-code-analysis
branch
from
27e0498
to
fccc3a9
Compare
|
@drewnoakes I think this is ready to be merged. |
drewnoakes
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, adding it via the designer saved us other accessibility bugs around that combo box (if I added it directly into the resource file, I got this error twice in the Accessibility Insights tool: An onscreen element must not have a null BoundingRectangle property).
Accessibility pass
On whole pane:
On Analysis level combo box:
Microsoft Reviewers: Open in CodeFlow