Fix Generate Event Handler code action #10967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
approved these changes
Oct 4, 2024
DustinCampbell
approved these changes
Oct 4, 2024
|
Just a note: I updated the description, this fixes code actions in general in FUSE, but also fixes the Generate Event Handler code action issue, which is unrelated to FUSE, and simply a genuine product bug |
davidwengier
changed the title
|
Got QB approval. Merging |
davidwengier
added a commit
that referenced
this pull request
Oct 30, 2024
…11122) Fixes #11112 Hopefully fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2290299/ but I'm not sure, as whilst OnAutoInsert was definitely broken for me, it didn't cause that repro. It just sent telemetry for a fault and did nothing in the IDE. Fixes https://developercommunity.visualstudio.com/t/Razor-editor-is-broken-in-1712-Preview-/10777527 ~but awaiting confirmation that FUSE is on for the user who reported the issue (@richardhauer I don't suppose that's you?)~ Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2294069 Sadly, in order to get a working test for this, I had to enable FUSE in cohosting. I say sadly because whilst it proves the cohosting tests are awesome, it does potentially break us into jail a little bit. But only in cohosting, so it's a pretty small jail :) The changes aren't very exciting, as this is just #10967 but for more than code actions (and these changes probably should have been part of that PR originally 🤦♂️), but each commit has an explanation for why it's there so commit-at-a-time might be enlightening. I could not resist a little clean up, but what's one little deleted service between friends?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of the commit from #10959 that fixes code actions in FUSE, and fixing the generate event handler code action which is unrelated to FUSE, in case we decide we want to take it for 17.12 P3
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2268945