Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize _Imports.razor in the source generator #10992

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Recognize _Imports.razor in the source generator #10992

merged 1 commit into from
Oct 10, 2024

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Oct 9, 2024

Fixes #10991.

@jjonescz jjonescz added the area-compiler Umbrella for all compiler issues label Oct 9, 2024
@jjonescz jjonescz marked this pull request as ready for review October 9, 2024 13:28
@jjonescz jjonescz requested a review from a team as a code owner October 9, 2024 13:28
chsienki
chsienki approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@chsienki chsienki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically a breaking change, right? I'm totally OK with taking it but want to call it out.

@jjonescz jjonescz merged commit fe4c0a9 into dotnet:main Oct 10, 2024
12 checks passed
@jjonescz jjonescz deleted the 10991-Imports branch October 10, 2024 08:31
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 10, 2024
This was referenced Oct 15, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Oct 29, 2024
Closed
@phil-allen-msft phil-allen-msft modified the milestones: Next, 17.13 P1 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chsienki chsienki chsienki approved these changes

@333fred 333fred 333fred approved these changes

Assignees
No one assigned
Labels
area-compiler Umbrella for all compiler issues
Projects
None yet
Milestone
17.13 P1
Development

Successfully merging this pull request may close these issues.

_Imports.razor not recognized correctly in the source generator
4 participants
@jjonescz @333fred @chsienki @phil-allen-msft