Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDocumentSnapshot finally gets ValueTasks and CancellationTokens #11002

Merged
merged 10 commits into from
Oct 14, 2024
Merged

IDocumentSnapshot finally gets ValueTasks and CancellationTokens #11002

merged 10 commits into from
Oct 14, 2024

Commits on Oct 11, 2024

  1. Use TextLoader and TextAndVersion in DocumentState

    @DustinCampbell
    DustinCampbell committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6c4bfda View commit details
    Browse the repository at this point in the history

  2. Switch IDocumentSnapshot.GetTextVersionAsync to ValueTask

    @DustinCampbell
    DustinCampbell committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0fe0b44 View commit details
    Browse the repository at this point in the history

  3. Switch IDocumentSnapshot.GetTextAsync to ValueTask

    @DustinCampbell
    DustinCampbell committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0cca69b View commit details
    Browse the repository at this point in the history

  4. Pass a CancellationToken to GetTextAsync and GetTextVersionAsync

    @DustinCampbell
    DustinCampbell committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5adac61 View commit details
    Browse the repository at this point in the history

  5. Fix up some unit tests

    @DustinCampbell
    DustinCampbell committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b537b48 View commit details
    Browse the repository at this point in the history

  6. Switch GetCSharpSyntaxTreeAsync to ValueTask and cache its result

    @DustinCampbell
    DustinCampbell committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6dcfda5 View commit details
    Browse the repository at this point in the history

  7. Switch IDocumentSnapshot.GetGenerateOutputAsync to ValueTask

    @DustinCampbell
    DustinCampbell committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    85d588c View commit details
    Browse the repository at this point in the history

  8. Pass CancellationToken to GetGeneratedOutputAsync 

    This commit is ginormous because I needed to thread cancellation tokens around everywhere.
    @DustinCampbell
    DustinCampbell committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e2abf82 View commit details
    Browse the repository at this point in the history

  9. Move and rename GetCSharpSyntaxTree extension method 

    This moves GetCSharpSyntaxTree from RazorCodeDocumentExtensions to be a static method on DocumentSnapshot. This should help keep it from being called in co-hosting scenarios.
    @DustinCampbell
    DustinCampbell committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    8020768 View commit details
    Browse the repository at this point in the history

  10. Now that GetTextAsync is cancellable, remove throw on cancel requested

    @DustinCampbell
    DustinCampbell committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ae867ab View commit details
    Browse the repository at this point in the history