Add support for directive attribute descriptions #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the `RazorCompletionItem` type to no longer contain a `Documentation`/`Description` property because in completion scenarios descriptions are never readily available and don't make a lot of sense being on the completion item itself. This is also how Roslyn does completions. - We now utilize an item bag on `RazorCompletionItem`s to hold description data. Currently there's just two type of completion descriptions (directive and attribute). Based off of the completion item kind (directive or attribute) we can extract the appropriate description. The goal of this new description type was to represent all data for a completion in an unstructured way so each platform can display it using its own capabilities. - Added a description factory to convert description items into classified containers. Tried to replicate WTE's description look as much as possible. - Left out documentation parsing. Will do this at a later date; however directive attributes rarely have documentation specific pieces that require parsing so we handle the 90% case. - Updated existing tests to reflect the new documentation mechanisms for RazorCompletionItems. - Added new tests to validate the completion source and the description factory. dotnet/aspnetcore#6364
12 tasks
|
Merging this into the parameter completion PR, will address feedback on the base completion pr (the one for names) to avoid mass re-builds / delays. We're looking to get a VS insertion out today. |
ghost
deleted the
| // Microsoft.AspnetCore.Components. | ||
| tagHelperTypeNamePrefix = tagHelperTypeName.Substring(0, afterLastDot); | ||
|
|
||
| // And the type name looks like BindBinds |
| { | ||
| if (_items == null) | ||
| { | ||
| lock (this) |
There was a problem hiding this comment.
Use explicit lock object?
| } | ||
|
|
||
| [Fact] | ||
| public void GetAttributeParameterCompletions_ReturnsCompletion() | ||
| { | ||
| // Arrange | ||
| var expectedCompletion = new RazorCompletionItem("format", "format", string.Empty, RazorCompletionItemKind.DirectiveAttributeParameter); | ||
|
|
||
|
|
||
| // Act |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RazorCompletionItemtype to no longer contain aDocumentation/Descriptionproperty because in completion scenarios descriptions are never readily available and don't make a lot of sense being on the completion item itself. This is also how Roslyn does completions.RazorCompletionItems to hold description data. Currently there's just two type of completion descriptions (directive and attribute). Based off of the completion item kind (directive or attribute) we can extract the appropriate description. The goal of this new description type was to represent all data for a completion in an unstructured way so each platform can display it using its own capabilities.Note: This accomplishes bullet point six of dotnet/aspnetcore#6364 (comment)
dotnet/aspnetcore#6364