Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly reference Roslyn compiler toolset version that will ship in preview 7 #727

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Explicitly reference Roslyn compiler toolset version that will ship in preview 7 #727

merged 2 commits into from
Jul 3, 2019

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Jul 2, 2019

@dougbu
Explicitly reference Roslyn compiler toolset version that will ship i…
4368272 
…n preview 7

- see also dotnet/efcore#16370 and dotnet/efcore#16385 discussions
- grab latest from the '.NET Core 3 Release' channel
@dougbu dougbu requested review from wtgodbe and a team July 2, 2019 22:49
@dougbu
Copy link
Member Author

dougbu commented Jul 2, 2019

@wtgodbe new subscription for 'release/3.0-preview7' is '9516c447-64e2-49be-1c34-08d6fb3704ce'

@wtgodbe
Copy link
Member

wtgodbe commented Jul 2, 2019

Checking that Versions.props and Version.Details.xml match
##[error]Missing version variable 'MicrosoftNetCompilersToolsetPackageVersion' in the 'Automated' property group in F:\workspace_work\1\s/eng/Versions.props
error: Missing version variable 'MicrosoftNetCompilersToolsetPackageVersion' in the 'Automated' property group in F:\workspace_work\1\s/eng/Versions.props
##[error]eng\Versions.props(,): error : Version variable 'MicrosoftNetCompilersToolsetVersion' does not have a matching entry in Version.Details.xml. See https://github.com/aspnet/AspNetCore/blob/master/docs/ReferenceResolution.md for instructions on how

wtgodbe
wtgodbe reviewed Jul 2, 2019
View reviewed changes
eng/Versions.props Outdated
@@ -68,6 +70,8 @@
<SystemDiagnosticsDiagnosticSourcePackageVersion>4.6.0-preview7.19329.3</SystemDiagnosticsDiagnosticSourcePackageVersion>
<SystemTextEncodingsWebPackageVersion>4.6.0-preview7.19329.3</SystemTextEncodingsWebPackageVersion>
<SystemReflectionMetadataPackageVersion>1.7.0-preview7.19329.3</SystemReflectionMetadataPackageVersion>
<!-- Packages from dotnet/roslyn -->
<MicrosoftNetCompilersToolsetVersion>3.3.0-beta1-19351-01</MicrosoftNetCompilersToolsetVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be MicrosoftNetCompilersToolsetPackageVersion

@wtgodbe
Copy link
Member

wtgodbe commented Jul 3, 2019

@dougbu I've switched to MicrosoftNetCompilersToolsetPackageVersion as this can't be merged without CodeCheck passing, and I've verified locally that darc updates still work with that property name.

@wtgodbe wtgodbe merged commit a335453 into release/3.0-preview7 Jul 3, 2019
@ghost ghost deleted the dougbu/update.compiler branch July 3, 2019 02:02
dougbu
dougbu commented Jul 3, 2019
View reviewed changes
Directory.Build.targets
@@ -11,7 +11,7 @@
<ItemGroup>
<!-- Track compiler separately from Arcade.-->
<PackageReference Include="Microsoft.Net.Compilers.Toolset"
Version="$(MicrosoftNetCompilersToolsetVersion)"
Version="$(MicrosoftNetCompilersToolsetPackageVersion)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get darc to accept MicrosoftNetCompilersToolsetPackageVersion when I tried in EF Core and it updated Version.props correctly using MicrosoftNetCompilersToolsetVersion. But, I agree MicrosoftNetCompilersToolsetVersion looked weird. Glad to see this fixed.

@dougbu
Copy link
Member Author

dougbu commented Jul 3, 2019

Thanks @wtgodbe❕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougbu @wtgodbe